Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Production site at https://sailbotpolaris.com was experiencing "Failed to fetch" errors for all API requests.
API services were constructing absolute URLs using the server IP address (http://164.92.120.218:3005/api/gps), which caused mixed content errors when the site runs on HTTPS.
Solution
Use relative URLs in production instead of absolute IP-based URLs.
Created lib/apiUrl.ts that detects hostname - returns /api/* for production (resolves to https://sailbotpolaris.com/api/) and http://localhost:3005/api/ for development.
also updated all 7 service files and DownloadData.js to use the new getApiUrl() helper.
Verification
Local development tested and working
Will have to verify on prod, once this is merged to main