Draft
Conversation
…nce the new 'layout' type
…split screening possible
… y levels: works outside of dropdown!
…of draggable item in dropdown
fix: truncate overflowing graph labels with ellipsis in dropdown items
fyang151
reviewed
Mar 18, 2026
Contributor
fyang151
left a comment
fyang151
left a comment
There was a problem hiding this comment.
this is cool! when youre dragging over to make a split horizontal graph, what do you think about resizing the other div on drag over? currently we just kinda have a ghost that sits on top of the div were dragging over
Contributor
|
I'd consider limiting it to only two graphs per row, ppl don't really need four on one row and it's difficult to read the graphs when they're that narrow. Also prevents confusion with moving around the graphs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split screen feature in the layout model added!
this change allows the graphs to be displayed 2 at a time, or 3 at a time or EVEN 4 IN ONE TIME
Comprehensive technical changes (claude summary)
Introduced Layout, LayoutItem, and GraphId types in GraphsTypes.ts. A layout item is either a single GraphId or a GraphId[] (split group)
Renamed graphs.order → graphs.layout in the Redux store and session storage
Added GraphsLayoutHelpers.ts with pure layout manipulation helpers: moveGraph, moveGraphToIndex, extractGraph, and splitGraph
Replaced SortableContext/useSortable with useDraggable + a custom pointermove listener for richer drag intent detection (split vs. reorder vs. extract)
how to recreate change
-You can reorder the graphs via gap drop zones (highlighted with a blue line indicator)
-Split them alongside an existing item (left/right highlight on hover)
-Can also extract a graph out of a split group back into its own row