Draft
Conversation
Member
|
@nicholaspai sorry, I haven't reviewed this because it's been in draft -- would you like a review on this or are we not planning to move forward with it? |
Member
Author
@mrice32 I still think we want this reviewed as it seems more flexible going forward |
mrice32
approved these changes
May 16, 2023
Member
mrice32
left a comment
mrice32
left a comment
There was a problem hiding this comment.
Looks good! Do you see any issues with adding and removing chains in this setup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces and improves on the disabled chain logic introduced in #576 . Instead of storing a list of disabled chains, store the list of all enabled chains. This allows the dataworker to remove hardcoded list of chain ID indices and infer the disabled chain list (by comparing the CHAIN_ID_INDICES list and the ENABLED_CHAINS list)