chore(shell): implement search function#236
Merged
Merged
Conversation
nishaq503
requested changes
Sep 19, 2025
nishaq503
left a comment
nishaq503
left a comment
Collaborator
There was a problem hiding this comment.
This looks pretty much like I imagined it would. I'm looking forward to when you have this ready
thoward27
force-pushed
the
feat/cli/search
branch
from
9fe1d18 to
753db94
Compare
nishaq503
requested changes
Oct 1, 2025
nishaq503
left a comment
nishaq503
left a comment
Collaborator
There was a problem hiding this comment.
Looks great over all. I want the following changes:
- Have the user provide an output directory and save search results as json/yaml files in that directory. I'm thinking for each query, for each alg, a list of the indices of and distances to the neighbors.
- Add an example to the README
thoward27
force-pushed
the
feat/cli/search
branch
from
abb5123 to
aa4e461
Compare
ndaniels
previously approved these changes
Nov 5, 2025
ndaniels
left a comment
ndaniels
left a comment
Collaborator
There was a problem hiding this comment.
This looks good now. Output dir and examples are fine.
chore(shell): implement search function chore: align to other cli targets chore(search): add output feat(shell): generate synthetic data
nishaq503
force-pushed
the
feat/cli/search
branch
from
aa4e461 to
9e6eb43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.