[CURA-13002] Defensive coding to hopefully fix concurrent modification.#1033
Merged
Merged
Conversation
A longstanding Sentry issue ('CURA-3RN'). Can't really reproduce, but an open cache for all objects of the same class is just asking for problems. Hopefully this constitutes a fix. If this turns out to be too slow, maybe instead it works if we just copy the 'getresult' value instead of giving a reference to the caller.
CURA-13002
Test Results1 tests ±0 0 ✅ ±0 1s ⏱️ ±0s For more details on these errors, see this check. Results for commit cfa06c3. ± Comparison against base commit 9887b85. ♻️ This comment has been updated with latest results. |
wawanbreton
approved these changes
Feb 26, 2026
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
Code itself looks good, but hard to tell the effect without going deep into it 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A longstanding Sentry issue ('CURA-3RN'). Can't really reproduce, but an open cache for all objects of the same class is just asking for problems. Hopefully this constitutes a fix. If this turns out to be too slow, maybe instead it works if we just copy the
getResult()value instead of giving a reference to the caller.