[CURA-13027] Be able to tell when a workspace is actively being loaded.#1035
Merged
Conversation
Needed for keep/discard in the front-end; when a workspace is loaded, the user sort of implictly agrees to 'keep' the changes, even if they put in 'always ask' (otherwise a screen would always pop-up after they load a workspace asking to undo the changes the file just made when loading...) -- this was fixed earlier in a different (wrong) way but that just shut out the keep/discard dialog _completely_. CURA-13027
Test Results1 tests ±0 0 ✅ ±0 1s ⏱️ ±0s For more details on these errors, see this check. Results for commit c18f5b1. ± Comparison against base commit 6f64683. ♻️ This comment has been updated with latest results. |
wawanbreton
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for keep/discard in the front-end; when a workspace is loaded, the user sort of implicitly agrees to 'keep' the changes, even if they put in 'always ask' (otherwise a screen would always pop-up after they load a workspace asking to undo the changes the file just made when loading...) -- this was fixed earlier in a different (wrong) way but that just shut out the keep/discard dialog completely.
See also: Ultimaker/Cura#21494