CURA-12754 dynamic dialogs#1038
Merged
Merged
Conversation
CURA-12754
CURA-12754
CURA-12754
Test Results2 404 tests 2 389 ✅ 22s ⏱️ Results for commit 1653133. ♻️ This comment has been updated with latest results. |
The (path: py.path.local) argument is deprecated, please use (collection_path: pathlib.Path) see https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
casperlamboo
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few functionalities for the dialogs cleaning:
deprecated_argumentdecorator to allow only deprecating an argument of a functioninitial_propertiesargument to thecreateQmlComponent: this helps creating QML components faster, since properties are set directly at construction, so it does not trigger event when actually setting their values. Also it can help when using a component having a Python object as a property.selfDestroyproperty to dialogs so that they are destroyed immediatly after being hiddenComes with Ultimaker/Cura#21570
CURA-12754