Skip to content

CURA-12913 UV unwrapping issues #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HellAholic merged 2 commits into from
Feb 12, 2026
Merged

CURA-12913 UV unwrapping issues #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6df1184
Properly handle groups of faces with only 1 face
wawanbreton Feb 11, 2026
b33686b
Bump version number
wawanbreton Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conandata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version: "1.0.0"
version: "1.0.1"
4 changes: 2 additions & 2 deletions src/unwrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ std::vector<Vector3F> calculateProjectionNormals(const std::vector<FaceData>& fa
};

// The unprocessed_faces is a sub-range of the faces list, that contains all the faces that have not been assigned to a group yet.
FaceDataRange unprocessed_faces = { .begin = faces_to_process.begin(), .end = faces_to_process.end() };
FaceDataRange unprocessed_faces = { .begin = std::next(faces_to_process.begin()), .end = faces_to_process.end() };

while (true)
{
Expand All @@ -85,7 +85,7 @@ std::vector<Vector3F> calculateProjectionNormals(const std::vector<FaceData>& fa
Vector3F summed_normals = std::accumulate(
current_faces_group.begin,
current_faces_group.end,
Vector3F(),
*project_normal,
[](const Vector3F& normal, const FaceData* face_data)
{
return normal + face_data->normal;
Expand Down
Loading