Rename tags#3
Closed
jesperhodge wants to merge 30 commits into
Closed
Conversation
tbain
reviewed
Mar 17, 2026
| setEditingRowId, | ||
| updateTagMutation, | ||
| }: UseEditActionsParams) => { | ||
| // TODO: Move this to tagTree together with very solid tests. |
Member
There was a problem hiding this comment.
Is this a TODO for this effort now, or a later effort?
Author
There was a problem hiding this comment.
I think I'll need to leave it for later in the interest of timeliness.
tbain
approved these changes
Mar 17, 2026
| }, | ||
| { description: 'Rename a sub-tag', tagName: 'the child tag' }, | ||
| { description: 'Rename a grandchild tag', tagName: 'the grandchild tag' }, | ||
| ]; |
Collaborator
There was a problem hiding this comment.
If we're expecting 4 levels of depth now, should this be updated to include the great grandchild tag as well?
| .map((cell, index) => { | ||
| const content = flexRender(cell.column.columnDef.cell, cell.getContext()); | ||
| const isFirstColumn = index === 0; | ||
| {editingRowId === `${row.original.id}:${String(row.original.value)}` ? ( |
Collaborator
There was a problem hiding this comment.
I think there should be a unit test to check both these cases
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…os pages Adds new generic components for gating certain features based on acceptance or acknowledgement of user agreements. It adds one alert that can be displayed where a feature (such as uploading) is blocked based on user agreeement, and it adds a wrapper component that disables the components inside it till the agreement has been accepted.
…2961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…enedx#2960) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…edx#2954) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.2 to 3.1.5. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.5) --- updated-dependencies: - dependency-name: minimatch dependency-version: 3.1.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
d439387 to
eaa833e
Compare
…openedx#2905) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 6. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5...v6) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: validate authz perms with studio instead of LMS * refactor: remove utils.ts and unused util
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
…openedx#2963) -------- Co-authored-by: Kyle McCormick <me@kyle.app>
Adds the Settings tab to the course info sidebar, which shows links to some course settings pages.
This implements openedx/modular-learning#253 , the task to add tag usage counts to the tags table under the taxonomies table. The corresponding backend part is openedx/openedx-core#506, which updates the count aggregations to ensure the correct count numbers are sent to the frontend. This frontend PR does not depend on the backend part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements openedx/modular-learning#259
Find Acceptance Criteria in parent ticket openedx/modular-learning#131 (this covers only the renaming part).
Note that deleting tags is out of scope for this PR.
Includes some updates from the create-tags branch that are not part of this branch.
Note that the renaming should be reflected in courses and modules, but in some instances the search index is not updated. For example, if you go to a library and try to filter by tag inside the library. This is a known issue with its own subticket and does not need to be tested here.
When you submit a duplicate tag, you get a completely messed up error response from the backend. That is a known issue with a subticket and also does not need to be fixed here.
Testing instructions