Skip to content

Rename tags#3

Closed
jesperhodge wants to merge 30 commits into
Unicon:jhodge/tree-table-basefrom
jesperhodge:jhodge/edit-delete-tags
Closed

Rename tags#3
jesperhodge wants to merge 30 commits into
Unicon:jhodge/tree-table-basefrom
jesperhodge:jhodge/edit-delete-tags

Conversation

@jesperhodge
Copy link
Copy Markdown

@jesperhodge jesperhodge commented Mar 12, 2026

Description

Implements openedx/modular-learning#259

Find Acceptance Criteria in parent ticket openedx/modular-learning#131 (this covers only the renaming part).

Note that deleting tags is out of scope for this PR.

Includes some updates from the create-tags branch that are not part of this branch.

Note that the renaming should be reflected in courses and modules, but in some instances the search index is not updated. For example, if you go to a library and try to filter by tag inside the library. This is a known issue with its own subticket and does not need to be tested here.

When you submit a duplicate tag, you get a completely messed up error response from the backend. That is a known issue with a subticket and also does not need to be fixed here.

Testing instructions

  • Open a taxonomy (if you don't have one, export taxonomy template -> re-import the exported file)
  • Find a top level tag that has child elements (you can see that by checking if there's an expand button on the left side). Take note of what the child elements are.
  • Go to a course module. Apply the tag.
  • Go to another course module. Apply a child tag of this tag but do not apply the tag.
  • Go back to the taxonomy and click on the three-dot-menu of the tag.
  • click "Rename"
  • test renaming: test save and cancel buttons, test escape and enter keyboard buttons
  • when an invalid character ";" or ">" is typed, or the tag has empty whitespace, an appropriate error message should appear and save button / Enter should be disabled
  • After successful save, a toast should be shown and the renamed tag should appear in the same place
  • The renamed tag should keep the child tags that the original tag had
  • reload the page
  • the renamed tag should now appear alphabetically sorted
  • The renamed tag should keep the child tags of the original tag
  • Go to the course modules that had the tag applied.
  • They should now have the renamed tag applied
  • They should have the same child tags applied
  • Go back to taxonomy
  • Using Chrome dev tools, block the request for renaming a tag (rename a tag -> right click on the network request -> block URL -> keep dev tools open
  • Rename another tag, triggering a blocked request
  • An appropriate inline error message should be shown
  • A banner should be shown indicating that the request failed, with an appropriate error message

@jesperhodge jesperhodge changed the title Jhodge/edit delete tags Rename tags Mar 16, 2026
@jesperhodge jesperhodge marked this pull request as ready for review March 16, 2026 17:20
@jesperhodge jesperhodge changed the base branch from qa/create-tags to jhodge/tree-table-base March 16, 2026 17:41
Comment thread src/taxonomy/tag-list/hooks.ts Outdated
setEditingRowId,
updateTagMutation,
}: UseEditActionsParams) => {
// TODO: Move this to tagTree together with very solid tests.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a TODO for this effort now, or a later effort?

Copy link
Copy Markdown
Author

@jesperhodge jesperhodge Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll need to leave it for later in the interest of timeliness.

},
{ description: 'Rename a sub-tag', tagName: 'the child tag' },
{ description: 'Rename a grandchild tag', tagName: 'the grandchild tag' },
];
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're expecting 4 levels of depth now, should this be updated to include the great grandchild tag as well?

.map((cell, index) => {
const content = flexRender(cell.column.columnDef.cell, cell.getContext());
const isFirstColumn = index === 0;
{editingRowId === `${row.original.id}:${String(row.original.value)}` ? (
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a unit test to check both these cases

jacobo-dominguez-wgu and others added 13 commits March 18, 2026 14:00
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…os pages

Adds new generic components for gating certain features based on acceptance or
acknowledgement of user agreements. It adds one alert that can be displayed
where a feature (such as uploading) is blocked based on user agreeement, and it
adds a wrapper component that disables the components inside it till the
agreement has been accepted.
…2961)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…enedx#2960)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…edx#2954)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.2 to 3.1.5.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.1.2...v3.1.5)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 3.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jesperhodge jesperhodge force-pushed the jhodge/edit-delete-tags branch from d439387 to eaa833e Compare March 27, 2026 20:31
brian-smith-tcril and others added 7 commits March 30, 2026 09:28
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 6.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v5...v6)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: validate authz perms with studio instead of LMS

* refactor: remove utils.ts and unused util
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Adds the Settings tab to the course info sidebar, which shows links to some course settings pages.
asajjad2 and others added 10 commits March 31, 2026 10:15
This implements openedx/modular-learning#253 , the task to add tag usage counts to the tags table under the taxonomies table. The corresponding backend part is openedx/openedx-core#506, which updates the count aggregations to ensure the correct count numbers are sent to the frontend. This frontend PR does not depend on the backend part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.