Add HTTP parser boundary checks to secure code review#1184
Open
tick25108-cpu wants to merge 1 commit into
Open
Add HTTP parser boundary checks to secure code review#1184tick25108-cpu wants to merge 1 commit into
tick25108-cpu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1174.
This updates
secure-code-reviewso HTTP request smuggling and parser-confusion risks are evaluated through proxy/framework evidence instead of broad heuristics.What changed
SCR-PARSE-01throughSCR-PARSE-06for parser ambiguity, forwarded framing headers, HTTP/2 downgrade gaps, unsafe raw-body middleware order, direct-backend-only tests, and benign size-limit overflags.Transfer-Encodingand global raw body consumers.Validation
git diff --checkSCR-PARSE-01throughSCR-PARSE-06, CWE-444, route-scoped webhook raw-body handling, and prompt-injection safety noticeBounty
Submitting this as an Improver contribution under the repository contribution guidelines. Payment details can be provided privately after maintainer acceptance.