Add container debug evidence gates#1194
Open
yZangEren wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name: container-security
Skill path:
skills/cloud/container-security/Fixes #1191.
What Was Wrong
The skill mentioned init, sidecar, and ephemeral containers as a common pitfall, but the main review flow and benchmark checklist did not force reviewers to prove which pod container arrays were checked.
That leaves a gap where a workload can look Restricted-compliant because
spec.containersis hardened, while a runtime debug path orspec.ephemeralContainersentry can still introduce a privileged root debug container with added capabilities.What This PR Fixes
This PR adds explicit ephemeral/debug-container evidence gates:
spec.containers,spec.initContainers, andspec.ephemeralContainerswere evaluated;pods/ephemeralcontainersevidence for RBAC, admission, audit, image policy, and runtime controls;Evidence
Before:
A reviewer could stop after the app container and miss a debug subresource path.
After:
and:
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Validation performed:
git diff --check.github/workflows/lint-skills.ymlspec.ephemeralContainers,pods/ephemeralcontainers, debug-container evidence, privileged ephemeral debug container,CM-10a, andCM-16Bounty Tier
Bounty Info