refactor config validation

[simonLeary42]

• moved config validation from UnityMailer to UnityDeployment
• simplified existing validation in UnityDeployment
• enabled typed config, so some integers and booleans need to be unquoted

root@web:/var/www/unity-web-portal/workers# ./configtest.php
PHP Fatal error:  Uncaught UnityWebPortal\lib\exceptions\InvalidConfigurationException: $CONFIG["expiry"]["idlelock_warning_days"] must be monotonically increasing in /var/www/unity-web-portal/resources/lib/UnityDeployment.php:81
Stack trace:
#0 /var/www/unity-web-portal/resources/lib/UnityDeployment.php(22): UnityWebPortal\lib\UnityDeployment::validateConfig(Array)
#1 /var/www/unity-web-portal/resources/config.php(5): UnityWebPortal\lib\UnityDeployment::getConfig()
#2 /var/www/unity-web-portal/resources/autoload.php(38): require_once('...')
#3 /var/www/unity-web-portal/workers/init.php(17): require_once('...')
#4 /var/www/unity-web-portal/workers/configtest.php(2): include('...')
#5 {main}
  thrown in /var/www/unity-web-portal/resources/lib/UnityDeployment.php on line 81

[Copilot]

Pull request overview

Refactors configuration validation by centralizing SMTP and expiry config checks in UnityDeployment and adds a CLI script to validate configs during deployment updates.

Changes:

• Moved SMTP validation out of UnityMailer into UnityDeployment and tightened ssl_verify handling to be boolean.
• Reworked expiry validation using assertion-based helpers and wrapped assertion failures as InvalidConfigurationException.
• Added a workers/configtest.php script and documented running it during upgrade; updated base config and changelog for the ssl_verify type change.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
workers/configtest.php	Adds a CLI entrypoint to load the app and trigger config validation.
resources/lib/UnityMailer.php	Removes SMTP config validation and updates ssl_verify check to strict boolean.
resources/lib/UnityDeployment.php	Centralizes SMTP/expiry validation using assertion-based helpers.
README.md	Documents running the new config test script during upgrade.
deployment/config.base.ini	Changes [smtp] ssl_verify default from string to boolean.
CHANGELOG.md	Notes the breaking change in [smtp] ssl_verify type.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.