Terms of Use Overlay Improvements#1366
Terms of Use Overlay Improvements#1366crhallberg wants to merge 5 commits intoUniversalViewer:devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks, @crhallberg. I like how this looks, but we might need a IIIF expert to weigh in on whether this solution is entirely acceptable. I think in many cases, the requiredStatement is going to include license information... but I think it's at least theoretically possible that the license information might be independent of the required statement. Not sure what the most appropriate behavior would be there, or how to decide what to do. One possible approach: check if the license URI is part of the required statement. If so, use the current behavior; if not, add a "License: [linked URI]" to the end. (Not sure if that's the best approach -- just brainstorming!) |
Yeah, I agree, it would be great to get someone with more IIIF experience to weigh in. Maybe we could share this PR in a relevant community or channel to get some feedback. I’m not an expert in this area either, so some extra eyes would definitely help. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @crhallberg -- this new version seems more streamlined and less controversial (though more IIIF input might be helpful). In any case, one minor observation for now.
| terms = requiredStatement.value; | ||
| } | ||
| if (!terms) { | ||
| const license = this.helper.getLicense(); |
There was a problem hiding this comment.
I believe that getLicense can potentially return a null value, so we should only construct the link below if we have a non-null license.
Uh oh!
There was an error while loading. Please reload this page.