Skip to content

Use relative paths for nav links#47

Open
shrey150 wants to merge 2 commits intomainfrom
fix/use-relative-nav-links
Open

Use relative paths for nav links#47
shrey150 wants to merge 2 commits intomainfrom
fix/use-relative-nav-links

Conversation

@shrey150
Copy link
Copy Markdown
Contributor

@shrey150 shrey150 commented Feb 20, 2026

Summary

  • All nav links in header.tsx were hardcoded as absolute URLs (https://v1michigan.com/apply, https://v1michigan.com/ship-it, etc.) even though they're routes on the same app
  • Changed them to relative paths (/apply, /ship-it, /events, /community, /join)
  • Left http://startupweek.v1michigan.com/ as-is since it's a different subdomain

This is more correct and avoids issues on preview deploys / localhost where the hardcoded domain wouldn't match.

Test plan

  • Verify all nav links still navigate correctly (desktop + mobile)
  • Test on a Vercel preview deploy to confirm relative paths work

🤖 Generated with Claude Code


Note

Low Risk
Simple link target updates in the header; low risk aside from potential misrouting/UTM regressions if any path is incorrect.

Overview
Updates components/header.tsx navigation to use relative internal routes (e.g. /apply, /ship-it, /events, /community, /join, preserving existing UTM params) instead of hardcoded https://v1michigan.com/... absolute URLs for both desktop and mobile menus.

External navigation (e.g. startupweek.v1michigan.com) is left as an absolute link.

Written by Cursor Bugbot for commit d874e66. This will update automatically on new commits. Configure here.

The header nav links were hardcoded to https://v1michigan.com/... which
is unnecessary since these routes are served by the same app. Using
relative paths (/apply, /ship-it, /events, etc.) is more correct and
avoids issues with environment mismatches (e.g. preview deploys,
localhost).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 20, 2026

Deploy Preview for v1-landing-page ready!

Name Link
🔨 Latest commit d874e66
🔍 Latest deploy log https://app.netlify.com/projects/v1-landing-page/deploys/6997ce93d81ec700091f29d7
😎 Deploy Preview https://deploy-preview-47--v1-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kllarena07
Copy link
Copy Markdown
Contributor

Has this been verified? I tried doing something similar when I was onboarded in early January and it just didn't work

@kllarena07 kllarena07 requested a review from dllliu March 5, 2026 18:13
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 5, 2026

Deploy Preview for v1-landing-page ready!

Name Link
🔨 Latest commit f47ae96
🔍 Latest deploy log https://app.netlify.com/projects/v1-landing-page/deploys/69a9e024749cf5000828a927
😎 Deploy Preview https://deploy-preview-47--v1-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dllliu
Copy link
Copy Markdown
Contributor

dllliu commented Mar 5, 2026

@kllarena07 i switched from turbopack to webpack, seems to have fixed it. Can you verify on ur machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants