Enable FCQN rule for Laravel pint

app/Exceptions/Handler.php

@@ -2,9 +2,20 @@
 
 namespace App\Exceptions;
 
+use Illuminate\Auth\Access\AuthorizationException;
+use Illuminate\Auth\AuthenticationException;
+use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Http\Request as HttpRequest;
+use Illuminate\Http\Response;
+use Illuminate\Queue\MaxAttemptsExceededException;
+use Illuminate\Session\TokenMismatchException;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Facades\Request;
+use Illuminate\Validation\ValidationException;
+use League\OAuth2\Server\Exception\OAuthServerException;
+use Symfony\Component\Console\Exception\CommandNotFoundException;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 use Throwable;
 
 class Handler extends ExceptionHandler
@@ -15,16 +26,16 @@ class Handler extends ExceptionHandler
      * @var array
      */
     protected $dontReport = [
-        \Illuminate\Auth\AuthenticationException::class,
-        \Illuminate\Auth\Access\AuthorizationException::class,
-        \Symfony\Component\HttpKernel\Exception\HttpException::class,
-        \Symfony\Component\Console\Exception\CommandNotFoundException::class,
-        \Illuminate\Database\Eloquent\ModelNotFoundException::class,
-        \Illuminate\Session\TokenMismatchException::class,
-        \Illuminate\Validation\ValidationException::class,
-        \Illuminate\Queue\MaxAttemptsExceededException::class,
-        \League\OAuth2\Server\Exception\OAuthServerException::class,
-        \App\Exceptions\Discord\DiscordUserInviteException::class,
+        AuthenticationException::class,
+        AuthorizationException::class,
+        HttpException::class,
+        CommandNotFoundException::class,
+        ModelNotFoundException::class,
+        TokenMismatchException::class,
+        ValidationException::class,
+        MaxAttemptsExceededException::class,
+        OAuthServerException::class,
+        Discord\DiscordUserInviteException::class,
     ];
 
     /**
@@ -61,8 +72,8 @@ public function report(Throwable $e)
     /**
      * Render an exception into an HTTP response.
      *
-     * @param  \Illuminate\Http\Request  $request
-     * @return \Illuminate\Http\Response
+     * @param  HttpRequest  $request
+     * @return Response
      */
     public function render($request, Throwable $e)
     {

app/Filament/Admin/Resources/AccountResource.php

@@ -4,6 +4,7 @@
 
 use App\Enums\QualificationTypeEnum;
 use App\Filament\Admin\Helpers\Resources\DefinesGatedAttributes;
+use App\Filament\Training\Resources\AccountResource\RelationManagers\WaitingListsRelationManager;
 use App\Models\Mship\Account;
 use App\Models\Roster;
 use AxonC\FilamentCopyablePlaceholder\Forms\Components\CopyablePlaceholder;
@@ -157,25 +158,25 @@ public static function table(Table $table): Table
     public static function getRelations(): array
     {
         return [
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\StatesRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\QualificationsRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\FeedbackRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\RolesRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\BansRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\NotesRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\EndorsementsRelationManager::class,
-            \App\Filament\Training\Resources\AccountResource\RelationManagers\WaitingListsRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\RetentionChecksRelationManager::class,
-            \App\Filament\Admin\Resources\AccountResource\RelationManagers\VisitTransferRelationManager::class,
+            AccountResource\RelationManagers\StatesRelationManager::class,
+            AccountResource\RelationManagers\QualificationsRelationManager::class,
+            AccountResource\RelationManagers\FeedbackRelationManager::class,
+            AccountResource\RelationManagers\RolesRelationManager::class,
+            AccountResource\RelationManagers\BansRelationManager::class,
+            AccountResource\RelationManagers\NotesRelationManager::class,
+            AccountResource\RelationManagers\EndorsementsRelationManager::class,
+            WaitingListsRelationManager::class,
+            AccountResource\RelationManagers\RetentionChecksRelationManager::class,
+            AccountResource\RelationManagers\VisitTransferRelationManager::class,
         ];
     }
 
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\AccountResource\Pages\ListAccounts::route('/'),
-            'view' => \App\Filament\Admin\Resources\AccountResource\Pages\ViewAccount::route('/{record}'),
-            'edit' => \App\Filament\Admin\Resources\AccountResource\Pages\EditAccount::route('/{record}/edit'),
+            'index' => AccountResource\Pages\ListAccounts::route('/'),
+            'view' => AccountResource\Pages\ViewAccount::route('/{record}'),
+            'edit' => AccountResource\Pages\EditAccount::route('/{record}/edit'),
         ];
     }
 

app/Filament/Admin/Resources/BanResource.php

@@ -103,8 +103,8 @@ public static function getRelations(): array
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\BanResource\Pages\ListBans::route('/'),
-            'view' => \App\Filament\Admin\Resources\BanResource\Pages\ViewBan::route('/{record}'),
+            'index' => BanResource\Pages\ListBans::route('/'),
+            'view' => BanResource\Pages\ViewBan::route('/{record}'),
         ];
     }
 }

app/Filament/Admin/Resources/EndorsementRequestResource.php

@@ -154,8 +154,8 @@ public static function table(Table $table): Table
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\EndorsementRequestResource\Pages\ListEndorsementRequests::route('/'),
-            'create' => \App\Filament\Admin\Resources\EndorsementRequestResource\Pages\CreateEndorsementRequest::route('/create'),
+            'index' => EndorsementRequestResource\Pages\ListEndorsementRequests::route('/'),
+            'create' => EndorsementRequestResource\Pages\CreateEndorsementRequest::route('/create'),
         ];
     }
 }

app/Filament/Admin/Resources/FeedbackResource.php

@@ -177,8 +177,8 @@ public static function table(Table $table): Table
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\FeedbackResource\Pages\ListFeedback::route('/'),
-            'view' => \App\Filament\Admin\Resources\FeedbackResource\Pages\ViewFeedback::route('/{record}'),
+            'index' => FeedbackResource\Pages\ListFeedback::route('/'),
+            'view' => FeedbackResource\Pages\ViewFeedback::route('/{record}'),
         ];
     }
 

app/Filament/Admin/Resources/PositionGroupResource.php

@@ -56,8 +56,8 @@ public static function getRelations(): array
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\PositionGroupResource\Pages\ListPositionGroups::route('/'),
-            'view' => \App\Filament\Admin\Resources\PositionGroupResource\Pages\ViewPositionGroup::route('/{record}'),
+            'index' => PositionGroupResource\Pages\ListPositionGroups::route('/'),
+            'view' => PositionGroupResource\Pages\ViewPositionGroup::route('/{record}'),
         ];
     }
 }

app/Filament/Admin/Resources/RoleResource.php

@@ -92,17 +92,17 @@ public static function table(Table $table): Table
     public static function getRelations(): array
     {
         return [
-            \App\Filament\Admin\Resources\RoleResource\RelationManagers\UsersRelationManager::class,
-            \App\Filament\Admin\Resources\RoleResource\RelationManagers\DelegatesRelationManager::class,
+            RoleResource\RelationManagers\UsersRelationManager::class,
+            RoleResource\RelationManagers\DelegatesRelationManager::class,
         ];
     }
 
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\RoleResource\Pages\ListRoles::route('/'),
-            'create' => \App\Filament\Admin\Resources\RoleResource\Pages\CreateRole::route('/create'),
-            'edit' => \App\Filament\Admin\Resources\RoleResource\Pages\EditRole::route('/{record}/edit'),
+            'index' => RoleResource\Pages\ListRoles::route('/'),
+            'create' => RoleResource\Pages\CreateRole::route('/create'),
+            'edit' => RoleResource\Pages\EditRole::route('/{record}/edit'),
         ];
     }
 }

app/Filament/Admin/Resources/RosterRestrictionResource.php

@@ -48,7 +48,7 @@ public static function getEloquentQuery(): Builder
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\RosterRestrictionResource\Pages\ListRosterRestrictions::route('/'),
+            'index' => RosterRestrictionResource\Pages\ListRosterRestrictions::route('/'),
         ];
     }
 }

app/Filament/Admin/Resources/SoloEndorsementResource.php

@@ -84,7 +84,7 @@ public static function table(Table $table): Table
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Admin\Resources\SoloEndorsementResource\Pages\ListSoloEndorsements::route('/'),
+            'index' => SoloEndorsementResource\Pages\ListSoloEndorsements::route('/'),
         ];
     }
 }

app/Filament/Training/Resources/WaitingListResource.php

@@ -138,10 +138,10 @@ public static function getRelations(): array
     public static function getPages(): array
     {
         return [
-            'index' => \App\Filament\Training\Resources\WaitingListResource\Pages\ListWaitingLists::route('/'),
-            'create' => \App\Filament\Training\Resources\WaitingListResource\Pages\CreateWaitingList::route('/create'),
-            'edit' => \App\Filament\Training\Resources\WaitingListResource\Pages\EditWaitingList::route('/{record}/edit'),
-            'view' => \App\Filament\Training\Resources\WaitingListResource\Pages\ViewWaitingList::route('/{record}'),
+            'index' => WaitingListResource\Pages\ListWaitingLists::route('/'),
+            'create' => WaitingListResource\Pages\CreateWaitingList::route('/create'),
+            'edit' => WaitingListResource\Pages\EditWaitingList::route('/{record}/edit'),
+            'view' => WaitingListResource\Pages\ViewWaitingList::route('/{record}'),
         ];
     }
 }

app/Http/Controllers/BaseController.php

@@ -6,15 +6,17 @@
 use Auth;
 use Carbon\Carbon;
 use Illuminate\Auth\Access\AuthorizationException;
+use Illuminate\Auth\Access\Response as AuthResponse;
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Auth\RedirectsUsers;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Routing\Controller;
 use Illuminate\Support\Facades\Cache;
 use Session;
 use View;
 
-class BaseController extends \Illuminate\Routing\Controller
+class BaseController extends Controller
 {
     use AuthorizesRequests {
         authorize as protected doAuthorize;
@@ -60,9 +62,9 @@ public function redirectTo()
      *
      * @param  mixed  $ability
      * @param  mixed|array  $arguments
-     * @return \Illuminate\Auth\Access\Response
+     * @return AuthResponse
      *
-     * @throws \Illuminate\Auth\Access\AuthorizationException
+     * @throws AuthorizationException
      */
     public function authorize($ability, $arguments = [])
     {

app/Http/Kernel.php

@@ -17,7 +17,7 @@ class Kernel extends HttpKernel
     protected $middleware = [
         \Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode::class,
         \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
-        \App\Http\Middleware\TrimStrings::class,
+        Middleware\TrimStrings::class,
         \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
     ];
 
@@ -29,16 +29,16 @@ class Kernel extends HttpKernel
     protected $middlewareGroups = [
         'web' => [
             // native
-            \App\Http\Middleware\EncryptCookies::class,
+            Middleware\EncryptCookies::class,
             \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
             \Illuminate\Session\Middleware\StartSession::class,
             \Illuminate\Session\Middleware\AuthenticateSession::class,
             \Illuminate\View\Middleware\ShareErrorsFromSession::class,
-            \App\Http\Middleware\VerifyCsrfToken::class,
+            Middleware\VerifyCsrfToken::class,
             \Illuminate\Routing\Middleware\SubstituteBindings::class,
 
             // custom
-            \App\Http\Middleware\TrackInactivity::class,
+            Middleware\TrackInactivity::class,
         ],
         'api' => [
             'throttle:60,1',
@@ -67,17 +67,17 @@ class Kernel extends HttpKernel
      */
     protected $routeMiddleware = [
         // native
-        'auth' => \App\Http\Middleware\Authenticate::class,
+        'auth' => Middleware\Authenticate::class,
         'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
         'bindings' => \Illuminate\Routing\Middleware\SubstituteBindings::class,
         'can' => \Illuminate\Auth\Middleware\Authorize::class,
-        'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
+        'guest' => Middleware\RedirectIfAuthenticated::class,
         'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
 
         // custom
         'admin' => Middleware\CheckAdminPermissions::class,
         'user.must.read.notifications' => Middleware\UserMustReadNotifications::class,
-        'api.tracking' => \App\Http\Middleware\ApiTracking::class,
+        'api.tracking' => Middleware\ApiTracking::class,
         'denyifbanned' => Middleware\DenyIfBanned::class,
         'mandatorypasswords' => Middleware\MandatoryPasswords::class,
         'redirecttointended' => Middleware\RedirectToIntended::class,
@@ -95,8 +95,8 @@ class Kernel extends HttpKernel
         \Illuminate\Session\Middleware\StartSession::class,
         \Illuminate\View\Middleware\ShareErrorsFromSession::class,
         \Illuminate\Session\Middleware\AuthenticateSession::class,
-        \App\Http\Middleware\TrackInactivity::class,
-        \App\Http\Middleware\Authenticate::class,
+        Middleware\TrackInactivity::class,
+        Middleware\Authenticate::class,
         \Illuminate\Routing\Middleware\SubstituteBindings::class,
         \Illuminate\Auth\Middleware\Authorize::class,
     ];

app/Http/Middleware/AdminPanelFilamentAccessMiddleware.php

@@ -3,16 +3,18 @@
 namespace App\Http\Middleware;
 
 use Closure;
+use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
+use Illuminate\Http\Response;
 use Illuminate\Support\Facades\Session;
 
 class AdminPanelFilamentAccessMiddleware
 {
     /**
      * Handle an incoming request.
      *
-     * @param  \Closure(\Illuminate\Http\Request): (\Illuminate\Http\Response|\Illuminate\Http\RedirectResponse)  $next
-     * @return \Illuminate\Http\Response|\Illuminate\Http\RedirectResponse
+     * @param  Closure(Request): (Response|RedirectResponse)  $next
+     * @return Response|RedirectResponse
      */
     public function handle(Request $request, Closure $next)
     {

app/Http/Requests/VisitTransfer/ApplicationStartRequest.php

@@ -22,8 +22,8 @@ public function rules()
             'terms_hours_minimum_relevant' => 'required',
             'terms_recent_transfer' => 'required',
             'terms_90_day' => 'required',
-            'terms_not_staff' => 'required_if:application_type,'.\App\Models\VisitTransfer\Application::TYPE_TRANSFER,
-            'application_type' => 'required|in:'.\App\Models\VisitTransfer\Application::TYPE_TRANSFER.','.\App\Models\VisitTransfer\Application::TYPE_VISIT,
+            'terms_not_staff' => 'required_if:application_type,'.Application::TYPE_TRANSFER,
+            'application_type' => 'required|in:'.Application::TYPE_TRANSFER.','.Application::TYPE_VISIT,
             'training_team' => 'required|in:pilot,atc',
         ];
     }

app/Libraries/TeamSpeak.php

@@ -219,7 +219,7 @@ public static function checkMemberStanding(Client $client, Account $member)
      * Check a member has accepted any necessary notifications.
      *
      *
-     * @throws \App\Exceptions\TeamSpeak\ClientKickedFromServerException
+     * @throws ClientKickedFromServerException
      */
     public static function checkMemberMandatoryNotifications(Client $client, Account $member)
     {
@@ -251,7 +251,7 @@ public static function checkMemberMandatoryNotifications(Client $client, Account
      * Check the client's nickname is correct.
      *
      *
-     * @throws \App\Exceptions\TeamSpeak\ClientKickedFromServerException
+     * @throws ClientKickedFromServerException
      */
     public static function checkClientNickname(Client $client, Account $member)
     {
@@ -380,7 +380,7 @@ public static function checkClientChannelGroups(Client $client, Account $member)
      * Check the client's (allowed) idle time.
      *
      *
-     * @throws \App\Exceptions\TeamSpeak\ClientKickedFromServerException
+     * @throws ClientKickedFromServerException
      */
     public static function checkClientIdleTime(Client $client, Account $member)
     {
@@ -483,7 +483,7 @@ public static function banClient(Client $client, $reason, $duration)
      *
      * @param  string  $reason
      *
-     * @throws \App\Exceptions\TeamSpeak\ClientKickedFromServerException
+     * @throws ClientKickedFromServerException
      */
     public static function deactivateClient(Client $client, $reason)
     {

app/Models/Airport.php

@@ -17,7 +17,7 @@
  * @property float|null $latitude
  * @property float|null $longitude
  * @property int|null $elevation
- * @property-read \Illuminate\Database\Eloquent\Collection|\App\Models\Sys\Data\Change[] $dataChanges
+ * @property-read \Illuminate\Database\Eloquent\Collection|Sys\Data\Change[] $dataChanges
  *
  * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Airport whereElevation($value)
  * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Airport whereId($value)
@@ -41,10 +41,10 @@
  * @property \Carbon\Carbon|null $updated_at
  * @property-read mixed $controllers
  * @property-read mixed $pilots
- * @property-read \Illuminate\Database\Eloquent\Collection|\App\Models\Airport\Navaid[] $navaids
- * @property-read \Illuminate\Database\Eloquent\Collection|\App\Models\Airport\Procedure[] $procedures
- * @property-read \Illuminate\Database\Eloquent\Collection|\App\Models\Airport\Runway[] $runways
- * @property-read \Illuminate\Database\Eloquent\Collection|\App\Models\Atc\Position[] $positions
+ * @property-read \Illuminate\Database\Eloquent\Collection|Navaid[] $navaids
+ * @property-read \Illuminate\Database\Eloquent\Collection|Procedure[] $procedures
+ * @property-read \Illuminate\Database\Eloquent\Collection|Runway[] $runways
+ * @property-read \Illuminate\Database\Eloquent\Collection|Position[] $positions
  *
  * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Airport iCAO($icao)
  * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Airport uK()

app/Models/Airport/Navaid.php

@@ -19,7 +19,7 @@
  * @property string|null $remarks
  * @property \Carbon\Carbon|null $created_at
  * @property \Carbon\Carbon|null $updated_at
- * @property-read \App\Models\Airport $airport
+ * @property-read Airport $airport
  *
  * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Airport\Navaid whereAirportId($value)
  * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Airport\Navaid whereCreatedAt($value)