feat: Share PDF page extraction across PDF ingest paths#136
Open
gwokhou wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #135.
This PR introduces a shared PDF page extraction contract and routes PDF ingest paths through it where doing so preserves existing behavior:
PageContent,PdfExtractor,LocalPdfExtractor,pages_to_markdown, andpages_to_jsonget_page_content()as the first choice whenPAGEINDEX_API_KEYis set, then falls back to the configured extractorReviewer Note
Issue #135 asks for a configured PDF extraction engine to affect both short PDF Markdown and long PDF page JSON. This PR preserves the existing PageIndex Cloud page-content path when
PAGEINDEX_API_KEYis set because that path provides cloud OCR behavior for scanned or complex PDFs.That means
pdf_parsercontrols short PDFs and long-PDF local fallback JSON, but does not override cloud-modeget_page_content()output. Please confirm whether preserving cloud OCR priority is the desired compatibility behavior, or whether #135 should requirepdf_parserto control cloud-mode long PDF page JSON too.Validation
Result:
161 passed, 6 warnings in 1.35s.