Conversation
🦋 Changeset detectedLatest commit: bbdcae9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR adds "hide balance" support across the Dashboard summary cells and the market table's user balance columns using the existing
Confidence Score: 4/5Safe to merge after fixing the tooltip privacy leak in AccountHealthBar; all other changes are correct. One P1 defect: the AccountHealthBar tooltip reveals actual financial values (borrow balance, limit %) when balances are supposed to be hidden, directly undermining the feature's purpose. The fix is a one-liner. All other changes — HidableUserBalance usage in MarketTable columns and Summary cells — are correct and consistent with the existing pattern. apps/evm/src/components/AccountHealthBar/index.tsx — tooltip prop must also be masked when hiddenValues is set.
|
| Filename | Overview |
|---|---|
| apps/evm/src/components/AccountHealthBar/index.tsx | Adds hiddenValues prop to mask label text in the progress bar, but the tooltip still renders actual balance data when balances are hidden — a P1 defect. |
| apps/evm/src/containers/MarketTable/useColumns/index.tsx | Wraps userSupplyBalance, userBorrowBalance, and userBorrowLimitSharePercentage columns in HidableUserBalance — straightforward and consistent with the container's pattern. |
| apps/evm/src/pages/Dashboard/Markets/Positions/Summary/index.tsx | Wraps all user-facing balance cells in HidableUserBalance and passes HIDDEN_BALANCE_KEY to AccountHealthBar for label masking; the tooltip leak is the issue located in AccountHealthBar itself. |
Comments Outside Diff (1)
-
apps/evm/src/components/AccountHealthBar/index.tsx, line 138 (link)Tooltip exposes hidden balance values
When
hiddenValuesis set,whiteLeftTextandwhiteRightTextare masked correctly, buttooltipis still computed from the realreadableBorrowBalance,readableBorrowLimitUsedPercentage, andreadableModerateBorrowLimitvalues and passed unchanged toLabeledProgressBar → ProgressBar. A user who has enabled "hide balances" can hover over the progress bar and see their actual borrow balance and limit in the tooltip — defeating the privacy feature.
Reviews (1): Last reviewed commit: "chore: support hidden" | Re-trigger Greptile
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||

Jira ticket(s)
VPD-956
Changes