feat: add information on E-mode tooltip and market info#5495
feat: add information on E-mode tooltip and market info#5495cuzz-venus wants to merge 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 54cb054 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR adds tooltip descriptions to the E-mode and Isolation mode section headers on the Market page, and surfaces four new stats (
Confidence Score: 4/5Safe to merge after removing the debug console.log on line 27 of EModeInfo/index.tsx. One P1 finding (console.log left in production code) blocks a clean merge; all other changes are correct and well-structured. apps/evm/src/pages/Market/EModeInfo/index.tsx — remove console.log on line 27.
|
| Filename | Overview |
|---|---|
| apps/evm/src/pages/Market/EModeInfo/index.tsx | Passes tooltip translations to Mode components; contains an accidental debug console.log on line 27 that must be removed. |
| apps/evm/src/pages/Market/EModeInfo/Mode/index.tsx | Correctly wires optional tooltip prop to InfoIcon beside the mode title; clean implementation. |
| apps/evm/src/pages/Market/EModeInfo/Mode/types.ts | Adds optional tooltip string to ModeProps; straightforward and correct. |
| apps/evm/src/pages/Market/MarketInfo/index.tsx | Adds isBorrowable, collateralFactor, liquidationThreshold, and liquidationPenalty rows to the stats list; all fields are non-optional on the Asset type so no null-safety concern. |
| apps/evm/src/libs/translations/translations/en.json | Adds tooltip strings for eMode/isolationMode and new market-info labels; content is clear and well-placed. |
| apps/evm/src/libs/translations/translations/ja.json | New keys added with English strings instead of Japanese translations; same pattern repeated across ja, th, tr, vi, zh-Hans, zh-Hant. |
Comments Outside Diff (1)
-
apps/evm/src/pages/Market/EModeInfo/index.tsx, line 27 (link)Debug
console.logleft in production codeThis debug statement logs
pool.userEModeGroup?.idto the console on every render and should be removed before merging.
Reviews (1): Last reviewed commit: "feat: add information on tooltip" | Re-trigger Greptile
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Jira ticket(s)
VPD-951
Changes