Skip to content

feat: add information on E-mode tooltip and market info#5495

Open
cuzz-venus wants to merge 6 commits intomainfrom
feat/information-add
Open

feat: add information on E-mode tooltip and market info#5495
cuzz-venus wants to merge 6 commits intomainfrom
feat/information-add

Conversation

@cuzz-venus
Copy link
Copy Markdown
Contributor

@cuzz-venus cuzz-venus commented Apr 8, 2026

Jira ticket(s)

VPD-951

Changes

  • add information on E-mode tooltip
  • add market info
image image image

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 8, 2026

🦋 Changeset detected

Latest commit: 54cb054

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Apr 9, 2026 0:47am
dapp-testnet Ready Ready Preview Apr 9, 2026 0:47am
venus.io Ready Ready Preview Apr 9, 2026 0:47am

Request Review

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 8, 2026

Greptile Summary

This PR adds tooltip descriptions to the E-mode and Isolation mode section headers on the Market page, and surfaces four new stats (isBorrowable, collateralFactor, liquidationThreshold, liquidationPenalty) in the Market Info card.

  • A console.log(pool.userEModeGroup?.id) debug statement was accidentally left in EModeInfo/index.tsx (line 27) and will fire on every render in production — it must be removed before merging.

Confidence Score: 4/5

Safe to merge after removing the debug console.log on line 27 of EModeInfo/index.tsx.

One P1 finding (console.log left in production code) blocks a clean merge; all other changes are correct and well-structured.

apps/evm/src/pages/Market/EModeInfo/index.tsx — remove console.log on line 27.

Vulnerabilities

No security concerns identified. Changes are limited to UI display and translation strings; no new data access, auth boundaries, or user-input handling is introduced.

Important Files Changed

Filename Overview
apps/evm/src/pages/Market/EModeInfo/index.tsx Passes tooltip translations to Mode components; contains an accidental debug console.log on line 27 that must be removed.
apps/evm/src/pages/Market/EModeInfo/Mode/index.tsx Correctly wires optional tooltip prop to InfoIcon beside the mode title; clean implementation.
apps/evm/src/pages/Market/EModeInfo/Mode/types.ts Adds optional tooltip string to ModeProps; straightforward and correct.
apps/evm/src/pages/Market/MarketInfo/index.tsx Adds isBorrowable, collateralFactor, liquidationThreshold, and liquidationPenalty rows to the stats list; all fields are non-optional on the Asset type so no null-safety concern.
apps/evm/src/libs/translations/translations/en.json Adds tooltip strings for eMode/isolationMode and new market-info labels; content is clear and well-placed.
apps/evm/src/libs/translations/translations/ja.json New keys added with English strings instead of Japanese translations; same pattern repeated across ja, th, tr, vi, zh-Hans, zh-Hant.

Comments Outside Diff (1)

  1. apps/evm/src/pages/Market/EModeInfo/index.tsx, line 27 (link)

    P1 Debug console.log left in production code

    This debug statement logs pool.userEModeGroup?.id to the console on every render and should be removed before merging.

Reviews (1): Last reviewed commit: "feat: add information on tooltip" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 76.7% 38673 / 50420
🔵 Statements 76.7% 38673 / 50420
🔵 Functions 58.62% 605 / 1032
🔵 Branches 71.34% 4431 / 6211
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/pages/Market/EModeInfo/index.tsx 95.65% 55.55% 100% 95.65% 41-42
apps/evm/src/pages/Market/EModeInfo/Mode/index.tsx 98.07% 50% 25% 98.07% 47
apps/evm/src/pages/Market/MarketInfo/index.tsx 90.25% 50% 100% 90.25% 65, 103-112, 136-137, 158-160
Generated in workflow #13121 for commit 54cb054 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants