Skip to content

feat: support e-mode max ltv data#5500

Open
cuzz-venus wants to merge 5 commits intomainfrom
feat/ltv-data
Open

feat: support e-mode max ltv data#5500
cuzz-venus wants to merge 5 commits intomainfrom
feat/ltv-data

Conversation

@cuzz-venus
Copy link
Copy Markdown
Contributor

@cuzz-venus cuzz-venus commented Apr 9, 2026

Jira ticket(s)

VPD-952

Changes

  • add e-mode max ltv data
image image

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

🦋 Changeset detected

Latest commit: 486b0f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Apr 9, 2026 10:37am
dapp-testnet Ready Ready Preview Apr 9, 2026 10:37am
venus.io Ready Ready Preview Apr 9, 2026 10:37am

Request Review

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 9, 2026

Greptile Summary

This PR adds e-mode-aware Max LTV display to the MarketInfo header by passing accountAddress to useGetPool and resolving an effectiveCollateralFactor from pool.userEModeGroup.assetSettings when the user is in an active e-mode group. The logic is correct: the type of EModeAssetSettings.collateralFactor (number) matches Asset.collateralFactor, the fallback path is safe, and the useMemo dependency array is complete.

Confidence Score: 5/5

Safe to merge; only remaining finding is a P2 suggestion for test coverage.

All logic is correct, types align, the dependency array is complete, and no existing tests are broken. The single P2 comment is a test-coverage suggestion that does not affect runtime correctness.

No files require special attention.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename Overview
apps/evm/src/containers/Layout/Header/MarketInfo/index.tsx Passes accountAddress to useGetPool and derives effectiveCollateralFactor from e-mode asset settings when the user is in an e-mode group; logic and types are sound.
.changeset/twelve-moose-kneel.md Changeset entry for the patch; no issues.

Reviews (1): Last reviewed commit: "chore: support e-mode ltv data" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 76.68% 38652 / 50404
🔵 Statements 76.68% 38652 / 50404
🔵 Functions 58.62% 605 / 1032
🔵 Branches 71.35% 4431 / 6210
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/containers/Layout/Header/MarketInfo/index.tsx 0% 0% 0% 0% 1-169
Generated in workflow #13118 for commit 486b0f8 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant