Conversation
🦋 Changeset detectedLatest commit: 91ec505 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcb4bad to
67ccafe
Compare
67ccafe to
91ec505
Compare
|
@greptile |
Greptile SummaryThis PR migrates ~77 files to import One item worth confirming: Confidence Score: 5/5Safe to merge; all findings are P2 or lower and the import migration is mechanically consistent. The bulk of the change is a straightforward import-path migration with no functional risk. The one P2 note (refetch interval speedup in useGetSwapQuote) does not block merge — it's likely intentional for Yield+ but should be confirmed. The applySlippagePercentage fix is a correctness improvement. apps/evm/src/clients/api/queries/getSwapQuote/useGetSwapQuote.ts — verify that the 'fast' refetch interval is intentional Important Files Changed
Reviews (1): Last reviewed commit: "feat: query client import migration" | Re-trigger Greptile |
| >; | ||
|
|
||
| const refetchInterval = generatePseudoRandomRefetchInterval(); | ||
| const refetchInterval = generatePseudoRandomRefetchInterval('fast'); |
There was a problem hiding this comment.
Behaviour change mixed into refactoring PR
generatePseudoRandomRefetchInterval('fast') changes the swap-quote polling interval from 9–15 s to 3–6 s. This is a runtime behaviour change unrelated to the stated goal of migrating query-client imports. If it is intentional (e.g., for a Yield+ leveraged-position feature), it should be called out in the changeset/description so reviewers know it's deliberate and not an accidental inclusion.
There was a problem hiding this comment.
This is intentional, so that we keep the swap quote up to date,
Jira ticket(s)
VPD-634
VPD-632
VPD-629
VPD-640
VPD-633
VPD-638
VPD-637
VPD-643
VPD-635
VPD-639
Changes
queryClientmodule\n- keep the migration isolated from Yield+ feature behavior