Review pr 2497

app/src/main/java/com/theveloper/pixelplay/data/ai/AiHandler.kt

@@ -171,7 +171,7 @@ class AiHandler @Inject constructor(
                     AiSystemPromptType.TAGGING -> 0.4f
                     AiSystemPromptType.PLAYLIST, AiSystemPromptType.DAILY_MIX -> 0.6f
                     AiSystemPromptType.PERSONA -> 0.85f
-                    AiSystemPromptType.GENERAL -> 0.7f
+                    AiSystemPromptType.GENERAL, AiSystemPromptType.LYRICS -> 0.7f
                 }
             } else temperature
         } else params.temperature
@@ -182,7 +182,7 @@ class AiHandler @Inject constructor(
         val basePersona = getBasePersona(userProvider)
         val combinedSystemPrompt = promptEngine.buildPrompt(basePersona, type, context)
 
-        val hash = (userProvider.name + combinedSystemPrompt + prompt).sha256()
+        val hash = (type.name + userProvider.name + combinedSystemPrompt + prompt).sha256()
 
         cacheDao.getCache(hash)?.let { cached ->
             val age = System.currentTimeMillis() - cached.timestamp

app/src/main/java/com/theveloper/pixelplay/data/ai/AiSystemPromptEngine.kt

@@ -11,6 +11,7 @@ enum class AiSystemPromptType {
     MOOD_ANALYSIS,
     PERSONA,
     DAILY_MIX,
+    LYRICS,
     GENERAL
 }
 
@@ -182,6 +183,16 @@ class AiSystemPromptEngine @Inject constructor() {
                 $dailyMixPersonaPrompt
             """.trimIndent()
 
+            AiSystemPromptType.LYRICS -> """
+                <role>Song lyrics translator — you translate lyrics between languages while preserving structure.</role>
+                <strategy>
+                - Preserve ALL timestamps and line structure exactly.
+                - Output each original line followed by its translation on the next line.
+                - Never add explanations, labels, or formatting beyond the requested format.
+                - If the source is already in the target language, respond with: ALREADY_IN_TARGET_LANGUAGE
+                </strategy>
+            """.trimIndent()
+
             AiSystemPromptType.GENERAL -> """
                 <role>PixelPlayer Assistant — a knowledgeable music companion.</role>
                 <strategy>

app/src/main/java/com/theveloper/pixelplay/data/ai/provider/AiProvider.kt

@@ -3,18 +3,23 @@ package com.theveloper.pixelplay.data.ai.provider
 /**
  * Enum representing available AI providers
  */
-enum class AiProvider(val displayName: String, val requiresApiKey: Boolean, val hasConfigurableUrl: Boolean = false) {
-    GEMINI("Google Gemini", requiresApiKey = true),
-    DEEPSEEK("DeepSeek", requiresApiKey = true),
-    GROQ("Groq", requiresApiKey = true),
-    MISTRAL("Mistral", requiresApiKey = true),
-    NVIDIA("NVIDIA NIM", requiresApiKey = true),
-    KIMI("Kimi (Moonshot)", requiresApiKey = true),
-    GLM("Zhipu GLM", requiresApiKey = true),
-    OPENAI("OpenAI", requiresApiKey = true),
-    OPENROUTER("OpenRouter", requiresApiKey = true),
-    OLLAMA("Ollama", requiresApiKey = true),
-    CUSTOM("Custom Provider", requiresApiKey = true, hasConfigurableUrl = true);
+enum class AiProvider(
+    val displayName: String,
+    val requiresApiKey: Boolean,
+    val hasConfigurableUrl: Boolean = false,
+    val description: String = ""
+) {
+    GEMINI("Google Gemini", requiresApiKey = true, description = "Google's flagship AI models (Gemini 1.5/2.0)"),
+    DEEPSEEK("DeepSeek", requiresApiKey = true, description = "Open-source reasoning models via DeepSeek API"),
+    GROQ("Groq", requiresApiKey = true, description = "Ultra-fast inference with Groq LPU hardware"),
+    MISTRAL("Mistral", requiresApiKey = true, description = "Mistral AI's efficient and powerful models"),
+    NVIDIA("NVIDIA NIM", requiresApiKey = true, description = "NVIDIA's optimized inference microservices"),
+    KIMI("Kimi (Moonshot)", requiresApiKey = true, description = "Moonshot AI's long-context Kimi models"),
+    GLM("Zhipu GLM", requiresApiKey = true, description = "Zhipu AI's bilingual GLM series"),
+    OPENAI("OpenAI", requiresApiKey = true, description = "GPT-4o, GPT-4, and other OpenAI models"),
+    OPENROUTER("OpenRouter", requiresApiKey = true, description = "Unified access to 200+ models via OpenRouter"),
+    OLLAMA("Ollama", requiresApiKey = true, description = "Local models via Ollama (requires running server)"),
+    CUSTOM("Custom Provider", requiresApiKey = true, hasConfigurableUrl = true, description = "Any OpenAI-compatible API endpoint");
 
     companion object {
         fun fromString(value: String): AiProvider {

app/src/main/java/com/theveloper/pixelplay/data/repository/MusicRepository.kt

@@ -77,12 +77,6 @@ interface MusicRepository {
         storageFilter: com.theveloper.pixelplay.data.model.StorageFilter = com.theveloper.pixelplay.data.model.StorageFilter.ALL
     ): Flow<Int>
 
-    /**
-     * Returns the count of songs in the library.
-     * @return Flow emitting the current song count.
-     */
-    fun getSongCountFlow(): Flow<Int>
-
     /**
      * Returns the count of cloud songs in the library.
      */

app/src/main/java/com/theveloper/pixelplay/data/repository/MusicRepositoryImpl.kt

@@ -310,10 +310,6 @@ class MusicRepositoryImpl @Inject constructor(
         return songRepository.getFavoriteSongCountFlow(storageFilter)
     }
 
-    override fun getSongCountFlow(): Flow<Int> {
-        return musicDao.getSongCount().distinctUntilChanged()
-    }
-
     override fun getCloudSongCountFlow(): Flow<Int> {
         return musicDao.getCloudSongCount().distinctUntilChanged()
     }

app/src/main/java/com/theveloper/pixelplay/presentation/model/SettingsCategory.kt

@@ -10,6 +10,7 @@ import androidx.compose.material.icons.rounded.LibraryMusic
 import androidx.compose.material.icons.rounded.MusicNote
 import androidx.compose.material.icons.rounded.Palette
 import androidx.compose.material.icons.rounded.QueueMusic
+import androidx.compose.material.icons.rounded.Tune
 import androidx.compose.ui.graphics.vector.ImageVector
 import com.theveloper.pixelplay.R
 
@@ -62,6 +63,12 @@ enum class SettingsCategory(
         subtitleRes = R.string.settings_category_ai_subtitle,
         iconRes = R.drawable.gemini_ai
     ),
+    GENERATION_PARAMETERS(
+        id = "generation_parameters",
+        titleRes = R.string.settings_category_generation_parameters_title,
+        subtitleRes = R.string.settings_category_generation_parameters_subtitle,
+        icon = Icons.Rounded.Tune
+    ),
     BACKUP_RESTORE(
         id = "backup_restore",
         titleRes = R.string.settings_category_backup_title,

app/src/main/java/com/theveloper/pixelplay/presentation/screens/AiUsageComponents.kt

@@ -179,6 +179,7 @@ private fun formatPromptType(type: String): String {
         "MOOD_ANALYSIS" -> "Analysis"
         "PERSONA" -> "Persona"
         "DAILY_MIX" -> "Daily Mix"
+        "LYRICS" -> "Lyrics"
         "GENERAL" -> "General"
         else -> type.lowercase().replaceFirstChar { it.uppercase() }
     }

app/src/main/java/com/theveloper/pixelplay/presentation/screens/LibraryScreen.kt

@@ -1002,11 +1002,11 @@ fun LibraryScreen(
         }.collectAsStateWithLifecycle(initialValue = LibraryScreenPlayerProjection())
         val isLibraryContentEmpty by remember(playerViewModel) {
             combine(
-                playerViewModel.songCountFlow,
+                playerViewModel.allSongsFlow,
                 playerViewModel.albumsFlow,
                 playerViewModel.artistsFlow
-            ) { songCount, albums, artists ->
-                songCount == 0 && albums.isEmpty() && artists.isEmpty()
+            ) { songs, albums, artists ->
+                songs.isEmpty() && albums.isEmpty() && artists.isEmpty()
             }.distinctUntilChanged()
         }.collectAsStateWithLifecycle(initialValue = true)