Skip to content

Consolidate clang-format workflow into PR checks#97

Merged
ViTeXFTW merged 1 commit intodevfrom
claude/review-ci-workflows-NygjJ
Feb 23, 2026
Merged

Consolidate clang-format workflow into PR checks#97
ViTeXFTW merged 1 commit intodevfrom
claude/review-ci-workflows-NygjJ

Conversation

@ViTeXFTW
Copy link
Copy Markdown
Owner

Summary

Consolidated the separate clang-format.yaml workflow into the main pr-test.yml workflow to streamline CI/CD processes and reduce workflow duplication.

Key Changes

  • Merged workflows: Integrated the format job from clang-format.yaml into pr-test.yml as the first job in the pipeline
  • Renamed workflow: Changed workflow name from "PR Test" to "PR Checks" to better reflect its expanded scope
  • Updated job dependencies:
    • Made changes job depend on format job completion
    • Updated test job to depend on both format and changes jobs
    • Added if: always() conditions to ensure jobs run regardless of previous job status
  • Removed duplicate file: Deleted .github/workflows/clang-format.yaml as its functionality is now part of the main workflow
  • Added trigger types: Explicitly specified pull request trigger types (opened, synchronize, reopened) in the main workflow

Implementation Details

  • The format job runs first and automatically commits any clang-format changes to the PR branch
  • Subsequent jobs (changes and test) use if: always() to ensure they execute even if formatting changes were made, preventing workflow failures due to job dependencies
  • All formatting logic remains unchanged; only the workflow organization has been modified

https://claude.ai/code/session_011YTedovZwqggmR5K6yoZ8Q

Combine clang-format.yaml into pr-test.yml so that formatting is
enforced before tests run. Job dependency chain: format → changes → test.

- format job always runs first (clang-format, auto-commits fixes)
- changes job runs after format (if: always(), so tests aren't blocked by format failures)
- test job runs after both, only when cpp/test files are changed

Also aligns trigger to the pr-test branch filter (dev, main, release/**)
and sets permissions per-job (contents: write for format, pull-requests: read for changes).

https://claude.ai/code/session_011YTedovZwqggmR5K6yoZ8Q
@ViTeXFTW
Copy link
Copy Markdown
Owner Author

@greptileai

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Feb 23, 2026

Greptile Summary

Consolidated the standalone clang-format.yaml workflow into pr-test.yml to streamline CI/CD and reduce duplication.

  • Workflow renamed from "PR Test" to "PR Checks" to reflect expanded scope
  • format job added as first job with identical logic from deleted workflow
  • Job dependencies updated: changes depends on format, test depends on both format and changes
  • if: always() conditions ensure changes and test run even if format commits changes
  • Explicit PR trigger types added: opened, synchronize, reopened
  • Original clang-format.yaml deleted successfully

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Workflow consolidation is a pure refactoring - the format job logic is identical to the deleted workflow, job dependencies are correctly configured with if: always() to prevent blocking, and the changes only affect CI/CD organization without altering runtime behavior
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/clang-format.yaml File deleted as part of workflow consolidation
.github/workflows/pr-test.yml Workflow consolidated with clang-format job, proper job dependencies with if: always() conditions

Last reviewed commit: a2c1444

@ViTeXFTW ViTeXFTW marked this pull request as ready for review February 23, 2026 12:25
@ViTeXFTW ViTeXFTW merged commit 61dbddc into dev Feb 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants