Consolidate clang-format workflow into PR checks#97
Merged
Conversation
Combine clang-format.yaml into pr-test.yml so that formatting is enforced before tests run. Job dependency chain: format → changes → test. - format job always runs first (clang-format, auto-commits fixes) - changes job runs after format (if: always(), so tests aren't blocked by format failures) - test job runs after both, only when cpp/test files are changed Also aligns trigger to the pr-test branch filter (dev, main, release/**) and sets permissions per-job (contents: write for format, pull-requests: read for changes). https://claude.ai/code/session_011YTedovZwqggmR5K6yoZ8Q
Owner
Author
Greptile SummaryConsolidated the standalone
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: a2c1444 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidated the separate
clang-format.yamlworkflow into the mainpr-test.ymlworkflow to streamline CI/CD processes and reduce workflow duplication.Key Changes
formatjob fromclang-format.yamlintopr-test.ymlas the first job in the pipelinechangesjob depend onformatjob completiontestjob to depend on bothformatandchangesjobsif: always()conditions to ensure jobs run regardless of previous job status.github/workflows/clang-format.yamlas its functionality is now part of the main workflowopened, synchronize, reopened) in the main workflowImplementation Details
formatjob runs first and automatically commits any clang-format changes to the PR branchchangesandtest) useif: always()to ensure they execute even if formatting changes were made, preventing workflow failures due to job dependencieshttps://claude.ai/code/session_011YTedovZwqggmR5K6yoZ8Q