✨Smol feature being added to when guilds join#171
Open
EdgarSaldivar wants to merge 1 commit into
Open
Conversation
dudeofawesome
requested changes
Mar 8, 2023
dudeofawesome
left a comment
dudeofawesome
left a comment
Collaborator
There was a problem hiding this comment.
We shouldn't be relying on the bot being live when added to a new guild. Thus, we need to track whether or not we have sent the welcome message in order to not double-send.
Comment on lines
-77
to
+81
| await this.discord_helper.findOrCreateVirginityBotChannel(guild_ent); | ||
| const channel = await this.discord_helper.findOrCreateVirginityBotChannel( | ||
| guild_ent, | ||
| ); |
Collaborator
There was a problem hiding this comment.
I think that we might have an issue around channel creation. We should look through the logs to check that this actually works or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #116