Fixes critical installation failures observed on APatch and KernelSU, and cleans up redundant files. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deleted `post-fs-data.sh`. - This script contains broken "backup/restore" logic that failed because the `modules_update` directory is cleared before boot. - As per the README, legacy script-based prop fixes have been removed in this fork, rendering these empty/broken scripts unnecessary.
- Deleted `service.sh`. - This script contains broken "backup/restore" logic that failed because the `modules_update` directory is cleared before boot. - As per the README, legacy script-based prop fixes have been removed in this fork, rendering these empty/broken scripts unnecessary.
1. **Fixed `customize.sh` Logic & Pathing:** - Removed the manual `MODPATH` definition (which incorrectly resolved to `sh` on APatch) and manual directory creation. - The script now relies on the module manager's native extraction and `$MODPATH` variable, ensuring cross-manager compatibility and preventing the "empty folder" bug. 2. **Fixed Script Encoding (BOM & CRLF):** - `customize.sh` contained a UTF-8 Byte Order Mark (BOM) and Windows (CRLF) line endings. - This caused the kernel to fail reading the shebang (`#!/system/bin/sh`), resulting in "not found" errors during execution. The file has been converted to standard Unix format (LF) without BOM. - *Proof of error:* `curl -sL "..." | cat -v` showed `M-oM-;M-?#!/system/bin/sh`. 3. **Improved Config Persistence:** - Implemented a robust "Wipe & Replace" strategy for user configs. - If a user backup is detected (and is not empty), the default `config` folder—extracted automatically by the manager—is deleted (`rm -rf`) and replaced with the user's files.
VisionR1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
Fixed
customize.shLogic & Pathing:MODPATHdefinition (which incorrectly resolved toshon APatch) and manual directory creation.$MODPATHvariable, ensuring cross-manager compatibility and preventing the "empty folder" bug.Fixed Script Encoding (BOM & CRLF):
customize.shcontained a UTF-8 Byte Order Mark (BOM) and Windows (CRLF) line endings.#!/system/bin/sh), resulting in "not found" errors during execution. The file has been converted to standard Unix format (LF) without BOM.curl -sL "..." | cat -vshowedM-oM-;M-?#!/system/bin/sh.Improved Config Persistence:
configfolder—extracted automatically by the manager—is deleted (rm -rf) and replaced with the user's files.Removed Redundant Boot Scripts:
service.shandpost-fs-data.sh.Status: Tested and verified working on APatch and Magisk (Fresh Install & Upgrade scenarios).