Conversation
jguggenh
left a comment
There was a problem hiding this comment.
interesting. can you test this further? if the cleanup speed was supposed to be 500ms, there is no way it was functioning. id guess that however its determining "inactive" streams is not working, or at least wasn't working a month ago.
to test, just start everything up and then run a case with a ton of cassettes. for example, run two cassettes, save both, run two more, save both, run two more etc.
i think the reason this is working better is not that this change solves the web video server problem but rather all the work cornel has done to limit the streams he is accessing.
|
however, if we are now moving over to firefox, i think the number of streams we can simultaneously host increases (6 -> 14? something like that). in that case, maybe its a moot point for now whether the web video server is successfully closing inactive streams. |
|
Yeah, with Firefox we may not need any of our changes. After banging on this for a while on my device, it seemed like streams got picked up faster by doubling the cleanup frequency. But I rarely get infinite spinners so I'm not 100% certain that this would fix things for others. |
No description provided.