Skip to content

Conversation

@devonjkohler
Copy link
Contributor

@devonjkohler devonjkohler commented Jan 14, 2026

Motivation and Context

Please include relevant motivation and context of the problem along with a short summary of the solution.

Changes

Please provide a detailed bullet point list of your changes.

Testing

Please describe any unit tests you added or modified to verify your changes.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have run the devtools::document() command after my changes and committed the added files

Summary by CodeRabbit

  • Bug Fixes
    • Improved robustness of statistical modeling functions by implementing enhanced error handling for linear model fitting, preventing processing interruptions when model estimation encounters issues and enabling graceful fallback behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The change wraps a linear model fitting call within MSstatsSummarizeSingleLinear in a try() construct with silent = TRUE. This prevents exceptions from interrupting execution, allowing the function to gracefully handle fitting failures by logging warnings and returning NULL instead.

Changes

Cohort / File(s) Summary
Error handling improvement
R/dataProcess.R
Wrapped .fitLinearModel call in try(..., silent = TRUE) to catch and handle fitting failures gracefully, replacing the previous direct call that could raise exceptions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a skip, a try-catch block divine,
No more shall errors make our models decline,
With gentle silence wrapping up the call,
We gracefully recover, standing tall! 🥕✨



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86b5710 and a8b6da5.

📒 Files selected for processing (1)
  • R/dataProcess.R

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@devonjkohler devonjkohler merged commit 39266fb into devel Jan 14, 2026
2 of 3 checks passed
@github-actions
Copy link

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants