Upgraded djmoney from 1.1 to 2.0.1 version in requirements.txt#301
Open
Vardane wants to merge 2 commits intoVolontaria:developfrom
Open
Upgraded djmoney from 1.1 to 2.0.1 version in requirements.txt#301Vardane wants to merge 2 commits intoVolontaria:developfrom
Vardane wants to merge 2 commits intoVolontaria:developfrom
Conversation
…-authenticated users can view details of an event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What have you changed ?
How did you change it ?
Is there a special consideration?
None
(FYI: current 1.1 version breaks and returns an error message
web_1 | File "/code/api_volontaria/apps/position/models.py", line 12, in
web_1 | from djmoney.models.fields import MoneyField
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/models/fields.py", line 12, in
web_1 | from djmoney import forms
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/forms/init.py", line 1, in
web_1 | from .fields import * # noqa
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/forms/fields.py", line 4, in
web_1 | from djmoney.money import Money
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/money.py", line 9, in
web_1 | from moneyed.localization import _FORMATTER, format_money
web_1 | ModuleNotFoundError: No module named 'moneyed.localization')
Upgrading to 2.0.1 fixes the error. Tests run with no error.
Verification :
CONTRIBUTING.mdCONTRIBUTING.md