Skip to content

Use generics to improve Swift interop #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolaykasyanov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use generics to improve Swift interop #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CollectionChanges/VMBCollectionSectionChange.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ typedef BOOL (^VMBCollectionItemComparator)(id left, id right);
+ (instancetype)removeChange;

/// changes is NSArray<YACollectionItemChange>
+ (instancetype)incrementalChange:(NSArray *)changes;
+ (instancetype)incrementalChange:(NSArray<VMBCollectionItemChange *> *)changes;

- (void)ifReloadChange:(dispatch_block_t)reloadHandler
insert:(dispatch_block_t)insertHandler
remove:(dispatch_block_t)removeHandler
incremental:(void (^)(NSArray /* <VMBCollectionItemChange> */ *changes))incrementalHandler;
incremental:(void (^)(NSArray<VMBCollectionItemChange *> *changes))incrementalHandler;

@end

Expand Down
10 changes: 5 additions & 5 deletions CollectionChanges/VMBCollectionSectionChange.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ @implementation YACollectionSectionChangeReload
- (void)ifReloadChange:(dispatch_block_t)reloadHandler
insert:(dispatch_block_t)insertHandler
remove:(dispatch_block_t)removeHandler
incremental:(void (^)(NSArray *))incrementalHandler {
incremental:(void (^)(NSArray<VMBCollectionItemChange *> *))incrementalHandler {
reloadHandler();
}

Expand All @@ -33,7 +33,7 @@ @implementation YACollectionSectionChangeInsert
- (void)ifReloadChange:(dispatch_block_t)reloadHandler
insert:(dispatch_block_t)insertHandler
remove:(dispatch_block_t)removeHandler
incremental:(void (^)(NSArray *))incrementalHandler {
incremental:(void (^)(NSArray<VMBCollectionItemChange *> *))incrementalHandler {
insertHandler();
}

Expand All @@ -49,7 +49,7 @@ @implementation YACollectionSectionChangeRemove
- (void)ifReloadChange:(dispatch_block_t)reloadHandler
insert:(dispatch_block_t)insertHandler
remove:(dispatch_block_t)removeHandler
incremental:(void (^)(NSArray *))incrementalHandler {
incremental:(void (^)(NSArray<VMBCollectionItemChange *> *))incrementalHandler {
removeHandler();
}

Expand All @@ -67,7 +67,7 @@ @implementation YACollectionSectionChangeIncremental
- (void)ifReloadChange:(dispatch_block_t)reloadHandler
insert:(dispatch_block_t)insertHandler
remove:(dispatch_block_t)removeHandler
incremental:(void (^)(NSArray *))incrementalHandler {
incremental:(void (^)(NSArray<VMBCollectionItemChange *> *))incrementalHandler {
incrementalHandler(self.changes);
}

Expand Down Expand Up @@ -181,7 +181,7 @@ + (instancetype)incrementalChange:(NSArray *)changes {
- (void)ifReloadChange:(dispatch_block_t)reloadHandler
insert:(dispatch_block_t)insertHandler
remove:(dispatch_block_t)removeHandler
incremental:(void (^)(NSArray *))incrementalHandler {
incremental:(void (^)(NSArray<VMBCollectionItemChange *> *))incrementalHandler {
@throw [NSException exceptionWithName:NSInternalInconsistencyException
reason:@"This class is not meant to be subclassed"
userInfo:nil];
Expand Down