Conversation
alyashour
reviewed
Mar 10, 2026
alyashour
left a comment
Member
There was a problem hiding this comment.
All good & tested. Pls just move timestamps to SharePtr memory fields & will merge.
Contributor
Author
|
Changes made and tested in sim. Ready for merge! Thanks @alyashour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Request / Pull Request
Summary of Changes
Briefly describe what this MR/PR does and which issue/task it addresses.
Type of Change
Checklist (to be completed before review)
Related Issue / Task
Notes / Additional Context
TODO’s resolved:
• Age check for odometer, current lane, and entities added
• Added path loading for subscribed topics from the config file
planner.yaml• Moved state publishing from the loop to the constructor for initial state; did not include check to see if console is up (will talk about it with Principals)
• Cleaned up logic in the EventGenerator::update() method
Furthermore, all items in the
math_utilsfiles were moved to theap1::mathnamespace, and the code was refactored accordingly.