Skip to content

Tweaks across planning: resolved all TODOs#14

Merged
alyashour merged 3 commits into
mainfrom
tweaks
Mar 12, 2026
Merged

Tweaks across planning: resolved all TODOs#14
alyashour merged 3 commits into
mainfrom
tweaks

Conversation

@JustinRowbotham

@JustinRowbotham JustinRowbotham commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Merge Request / Pull Request

Summary of Changes

Briefly describe what this MR/PR does and which issue/task it addresses.

Type of Change

  • Minor improvements
  • Refactors

Checklist (to be completed before review)

  • Code follows team standards
  • Tested locally
  • Tests added / updated if relevant
  • Documentation updated if relevant
  • CI / checks pass

Related Issue / Task

  • Closes PC-128

Notes / Additional Context

TODO’s resolved:
• Age check for odometer, current lane, and entities added
• Added path loading for subscribed topics from the config file planner.yaml
• Moved state publishing from the loop to the constructor for initial state; did not include check to see if console is up (will talk about it with Principals)
• Cleaned up logic in the EventGenerator::update() method

Furthermore, all items in the math_utils files were moved to the ap1::math namespace, and the code was refactored accordingly.

@JustinRowbotham JustinRowbotham requested a review from a team as a code owner March 9, 2026 07:27

@alyashour alyashour left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good & tested. Pls just move timestamps to SharePtr memory fields & will merge.

@JustinRowbotham

Copy link
Copy Markdown
Contributor Author

Changes made and tested in sim. Ready for merge! Thanks @alyashour

@alyashour alyashour left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks!

@alyashour alyashour merged commit 1c9aa87 into main Mar 12, 2026
1 check passed
@alyashour alyashour deleted the tweaks branch March 12, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants