Add support for .net 8 through 10 Expand .NET version support to net8.0-net10.0#17
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThis PR adds multi-targeting for net8.0–net10.0, centralizes EF Core version ranges in a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
coderabbitai
Bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
README.md (1)
2-3: Minor grammar issue: sentence fragment.Line 3 starts with lowercase "and" as a sentence fragment. Consider combining with the previous sentence or capitalizing.
✏️ Suggested fix
-In this simple project we're going to expose the helper extension methods that we're using in our company. -and as a starting point we'll start with the Graph update method. +In this simple project we're going to expose the helper extension methods that we're using in our company, +and as a starting point we'll start with the Graph update method.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 2 - 3, The README contains a sentence fragment: "and as a starting point we'll start with the Graph update method." Fix it by either joining it to the previous sentence or capitalizing and rephrasing so it reads as a complete sentence; e.g., merge with the prior sentence to read "In this simple project we're going to expose the helper extension methods that we're using in our company, and as a starting point we'll start with the Graph update method." or change "and" to "As" and adjust punctuation for the second sentence.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Directory.Build.props`:
- Around line 1-7: TargetFrameworks in Directory.Build.props is missing net9.0
which causes build/test mismatches; update the TargetFrameworks value to include
net9.0 (e.g., net8.0;net9.0;net10.0) so library and TestModel produce net9.0
assets, and then add the corresponding conditional package reference in the
library project (Diwink.Extensions.EntityFrameworkCore.csproj) for the net9.0
TFMoniker using the same pattern used for EfCore9Version/EfCore10Version to
ensure correct EF Core package binding for .NET 9.
In
`@src/Diwink.Extensions.EntityFrameworkCore.TestModel/Diwink.Extensions.EntityFrameworkCore.TestModel.csproj`:
- Around line 8-14: The project file lacks a conditional ItemGroup for net9.0;
add an ItemGroup with Condition="'$(TargetFramework)' == 'net9.0'" containing
the PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer"
Version="$(EfCore9Version)" so the test model project mirrors the main library
when net9.0 is added to TargetFrameworks; update the
Diwink.Extensions.EntityFrameworkCore.TestModel.csproj by adding that net9.0
conditional block next to the existing net8.0 and net10.0 ItemGroup entries.
In
`@src/Diwink.Extensions.EntityFrameworkCore/Diwink.Extensions.EntityFrameworkCore.csproj`:
- Around line 16-22: Add a conditional ItemGroup for net9.0 in the
Diwink.Extensions.EntityFrameworkCore.csproj so the
Microsoft.EntityFrameworkCore package is referenced when TargetFramework is
net9.0; specifically, mirror the pattern used for net8.0 by adding an ItemGroup
with Condition "'$(TargetFramework)' == 'net9.0'" and a PackageReference
Include="Microsoft.EntityFrameworkCore" Version="$(EfCore9Version)" to align
with the EfCore9Version variable.
---
Nitpick comments:
In `@README.md`:
- Around line 2-3: The README contains a sentence fragment: "and as a starting
point we'll start with the Graph update method." Fix it by either joining it to
the previous sentence or capitalizing and rephrasing so it reads as a complete
sentence; e.g., merge with the prior sentence to read "In this simple project
we're going to expose the helper extension methods that we're using in our
company, and as a starting point we'll start with the Graph update method." or
change "and" to "As" and adjust punctuation for the second sentence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0fb81be2-5d26-4873-b974-9668c288e1fa
📒 Files selected for processing (7)
.github/workflows/dotnet-core.ymlREADME.mdsrc/Directory.Build.propssrc/Diwink.Extensions.EntityFrameworkCore.TestModel/Diwink.Extensions.EntityFrameworkCore.TestModel.csprojsrc/Diwink.Extensions.EntityFrameworkCore.Tests.Integration/Diwink.Extensions.EntityFrameworkCore.Tests.Integration.csprojsrc/Diwink.Extensions.EntityFrameworkCore.Tests.Unit/Diwink.Extensions.EntityFrameworkCore.Tests.Unit.csprojsrc/Diwink.Extensions.EntityFrameworkCore/Diwink.Extensions.EntityFrameworkCore.csproj
Comment on lines
+1
to
+7
| <Project> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net8.0;net10.0</TargetFrameworks> | ||
| <EfCore9Version>[9.0.14,10.0.0)</EfCore9Version> | ||
| <EfCore10Version>[10.0.5,11.0.0)</EfCore10Version> | ||
| </PropertyGroup> | ||
| </Project> |
Contributor
There was a problem hiding this comment.
Missing net9.0 from TargetFrameworks creates a build/test mismatch.
The TargetFrameworks property defines only net8.0;net10.0, but:
- Test projects override this to
net8.0;net9.0;net10.0 - The README claims ".NET 8-10" support
- The CI workflow installs SDKs for 8.x, 9.x, and 10.x
Since the library and TestModel projects inherit from this file, they won't produce net9.0 assets. When tests run against net9.0, NuGet will fall back to the net8.0 library assembly, which is inconsistent with the stated support range.
🔧 Proposed fix: Add net9.0 to TargetFrameworks
<Project>
<PropertyGroup>
- <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
+ <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
<EfCore9Version>[9.0.14,10.0.0)</EfCore9Version>
<EfCore10Version>[10.0.5,11.0.0)</EfCore10Version>
</PropertyGroup>
</Project>If net9.0 is added here, you'll also need to add the corresponding conditional package reference in the library project (Diwink.Extensions.EntityFrameworkCore.csproj).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/Directory.Build.props` around lines 1 - 7, TargetFrameworks in
Directory.Build.props is missing net9.0 which causes build/test mismatches;
update the TargetFrameworks value to include net9.0 (e.g.,
net8.0;net9.0;net10.0) so library and TestModel produce net9.0 assets, and then
add the corresponding conditional package reference in the library project
(Diwink.Extensions.EntityFrameworkCore.csproj) for the net9.0 TFMoniker using
the same pattern used for EfCore9Version/EfCore10Version to ensure correct EF
Core package binding for .NET 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit