Skip to content

Added possibility to export the error Response of the parser#31

Open
MK-2001 wants to merge 13 commits into
WaleedAshraf:masterfrom
8mk:master
Open

Added possibility to export the error Response of the parser#31
MK-2001 wants to merge 13 commits into
WaleedAshraf:masterfrom
8mk:master

Conversation

@MK-2001
Copy link
Copy Markdown

@MK-2001 MK-2001 commented Sep 7, 2023

As asked in #30
This PR added the possibility to log the error messages and details in the log of git action.

@8mk
Copy link
Copy Markdown

8mk commented Sep 8, 2023

Sorry I let a own testfile in the PR, which i cleaned up now. (That is why the tests are failed)

Copy link
Copy Markdown
Owner

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.
Minor comments.

Comment thread action.yml
errorResponse:
description: 'Output the detailed response of the validation'
default: "false"
required: true
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be a required, but optional property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants