upstream sync (without conflicts) by prajjwaldimri · Pull Request #5 · WarpBuilds/setup-dotnet

prajjwaldimri · 2025-07-21T12:37:29Z

No description provided.

* Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump undici from 5.28.3 to 5.28.4 * update checkout from v3 to v4 * Update test proxy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com>

* Bump fast-xml-parser from 4.3.6 to 4.4.1 Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.3.6 to 4.4.1. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v4.3.6...v4.4.1) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fix checks --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com>

This workflow file publishes new action releases to the immutable action package of the same name as this repo. This is part of the Immutable Actions project which is not yet fully released to the public. First party actions like this one are part of our initial testing of this feature.

Add workflow file for publishing releases to immutable action package

Upgrade IA Publish

* Revise `isGhes` logic * `isGhes` should not be exported * ran `npm run format` and `npm run build` * ran `npm run update-installers`

…#555) * update workflows * Upgrade micromatch Dependency * Fix ubuntu 22.04 label * exclude macos-latest * Upgrade cross-spawn Dependency and update-installers

…ons#566) * Use new .NET CDN URL * Update to latest install-dotnet scripts * Use signed version of new `install-dotnet.ps1` * Add fallback to old CDN URL

* upgrade cache to 4.0.0 * license update * failure fix * e2e failure fix

* Create dependabot.yml * update latest install scripts

Bumps [actions/publish-immutable-action](https://github.com/actions/publish-immutable-action) from 0.0.3 to 0.0.4. - [Release notes](https://github.com/actions/publish-immutable-action/releases) - [Commits](actions/publish-immutable-action@0.0.3...v0.0.4) --- updated-dependencies: - dependency-name: actions/publish-immutable-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @actions/http-client from 2.2.1 to 2.2.3 Bumps [@actions/http-client](https://github.com/actions/toolkit/tree/HEAD/packages/http-client) from 2.2.1 to 2.2.3. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/http-client/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/http-client) --- updated-dependencies: - dependency-name: "@actions/http-client" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix for the check failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>

* Bump undici from 5.28.4 to 5.28.5 Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.4...v5.28.5) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * fix for the check failures * fix for licensed check failure --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>

…ts (actions#572) * Remove logic for azureedge.net fallback in preparation for install script changes * remove extra spacing * Update README.md (actions#587) * upgrade cache from 3.2.4 to 4.0.0 (actions#586) * upgrade cache to 4.0.0 * license update * failure fix * e2e failure fix * Configure Dependabot settings (actions#585) * Create dependabot.yml * update latest install scripts * Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 (actions#590) Bumps [actions/publish-immutable-action](https://github.com/actions/publish-immutable-action) from 0.0.3 to 0.0.4. - [Release notes](https://github.com/actions/publish-immutable-action/releases) - [Commits](actions/publish-immutable-action@0.0.3...v0.0.4) --- updated-dependencies: - dependency-name: actions/publish-immutable-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @actions/http-client from 2.2.1 to 2.2.3 (actions#592) * Bump @actions/http-client from 2.2.1 to 2.2.3 Bumps [@actions/http-client](https://github.com/actions/toolkit/tree/HEAD/packages/http-client) from 2.2.1 to 2.2.3. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/http-client/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/http-client) --- updated-dependencies: - dependency-name: "@actions/http-client" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix for the check failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> * Bump undici from 5.28.4 to 5.28.5 (actions#596) * Bump undici from 5.28.4 to 5.28.5 Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.4...v5.28.5) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * fix for the check failures * fix for licensed check failure --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com> * Remove old URLs from E2E tests workflow --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ben Wells <benwells@github.com> Co-authored-by: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aparna Jyothi <aparnajyothi-y@github.com>

Co-authored-by: “gowridurgad” <“hgowridurgad@github.com>

Bumps [husky](https://github.com/typicode/husky) from 8.0.3 to 9.1.7. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v8.0.3...v9.1.7) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @actions/glob from 0.4.0 to 0.5.0 Bumps [@actions/glob](https://github.com/actions/toolkit/tree/HEAD/packages/glob) from 0.4.0 to 0.5.0. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/glob/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/glob) --- updated-dependencies: - dependency-name: "@actions/glob" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix CI failures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HarithaVattikuti <73516759+HarithaVattikuti@users.noreply.github.com>

Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 9.1.0 to 10.1.5. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v9.1.0...v10.1.5) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-version: 10.1.5 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Copilot

Pull Request Overview

This PR implements an upstream sync merging changes from the main .NET installation scripts and updating dependencies to newer versions. The sync includes modernizing examples to use more current .NET versions and enhancing platform support.

Updates .NET Core index URL endpoints to use the new Microsoft builds domain
Enhances GitHub Enterprise detection logic to support cloud and localhost variants
Modernizes documentation examples from older .NET versions to current supported versions (8.0.x, 9.0.x)

Reviewed Changes

Copilot reviewed 35 out of 41 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/installer.ts	Updates .NET Core index URL endpoint
src/cache-utils.ts	Improves GitHub Enterprise Server detection logic
package.json	Updates dependencies to newer versions
externals/install-dotnet.sh	Extensive upstream sync with architecture support, quality options, and URL updates
externals/install-dotnet.ps1	Upstream sync with improved error handling and URL updates
README.md	Modernizes examples to use current .NET versions
.licenses/	Updates license files for dependency changes
.github/workflows/	Updates workflow dependencies and test matrix

Copilot · 2025-07-21T12:38:10Z

src/cache-utils.ts

+    process.env['GITHUB_SERVER_URL'] || 'https://github.com'
+  );
+
+  const hostname = ghUrl.hostname.trimEnd().toUpperCase();


[nitpick] The trimEnd() method without arguments removes whitespace characters, but hostnames shouldn't contain trailing whitespace. Consider using trim() for consistency or documenting why only trailing whitespace removal is needed.

Suggested change

const hostname = ghUrl.hostname.trimEnd().toUpperCase();

const hostname = ghUrl.hostname.trim().toUpperCase();

Copilot · 2025-07-21T12:38:11Z

externals/install-dotnet.sh

    else
        legacy_download_link=""
-        say_verbose "Cound not construct a legacy_download_link; omitting..."
+        say_verbose "Could not construct a legacy_download_link; omitting..."


Fixed typo: 'Cound' should be 'Could' - this correction improves the error message clarity.

Copilot · 2025-07-21T12:38:11Z

externals/install-dotnet.ps1

+    if (!$InstallRoot) {
+        $InstallRoot = "$env:LocalAppData\Microsoft\dotnet"
+    }
+    elseif ($InstallRoot -like "$env:ProgramFiles\dotnet\?*") {


[nitpick] The wildcard pattern ?* ensures at least one additional character after the base path. Consider using a more explicit check like -match with a regex pattern for better readability and maintainability.

Suggested change

elseif ($InstallRoot -like "$env:ProgramFiles\dotnet\?*") {

elseif ($InstallRoot -match "^$env:ProgramFiles\\dotnet\\.+") {

dependabot bot and others added 24 commits July 8, 2024 14:47

Fix failure checks (actions#545)

9be03d3

Merge pull request actions#548 from actions/Jcambass-patch-1

cbeba61

Add workflow file for publishing releases to immutable action package

Upgrade IA Publish

29640e4

Merge pull request actions#550 from actions/Jcambass-patch-2

2e0b259

Upgrade IA Publish

Revise isGhes logic (actions#556)

3e891b0

* Revise `isGhes` logic * `isGhes` should not be exported * ran `npm run format` and `npm run build` * ran `npm run update-installers`

Enhance Workflows, Update Dependencies and Installer Scripts (actions…

e4c228a

…#555) * update workflows * Upgrade micromatch Dependency * Fix ubuntu 22.04 label * exclude macos-latest * Upgrade cross-spawn Dependency and update-installers

V4 - Use new .NET CDN URLs and update to latest install scripts (acti…

87b7050

…ons#566) * Use new .NET CDN URL * Update to latest install-dotnet scripts * Use signed version of new `install-dotnet.ps1` * Add fallback to old CDN URL

Update README.md (actions#587)

f9d0f62

upgrade cache from 3.2.4 to 4.0.0 (actions#586)

4b37d22

* upgrade cache to 4.0.0 * license update * failure fix * e2e failure fix

Configure Dependabot settings (actions#585)

91b3793

* Create dependabot.yml * update latest install scripts

cache upgrade from 4.0.0 to 4.0.2 (actions#615)

67a3573

upgrade actions/cache to 4.0.3 (actions#622)

267870a

removes end-of-line dotnet versions (actions#647)

0f55b45

Co-authored-by: “gowridurgad” <“hgowridurgad@github.com>

Merge branch 'main' of github.com:actions/setup-dotnet into actions-main

f5e8dbe

prajjwaldimri requested review from Copilot and suryaoruganti July 21, 2025 12:37

prajjwaldimri self-assigned this Jul 21, 2025

Copilot AI reviewed Jul 21, 2025

View reviewed changes

fixes deps

03528c5

PrashantRaj18198 approved these changes Jul 21, 2025

View reviewed changes

prajjwaldimri merged commit d102702 into main Jul 21, 2025
100 of 104 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upstream sync (without conflicts)#5

upstream sync (without conflicts)#5
prajjwaldimri merged 25 commits intomainfrom
actions-main

prajjwaldimri commented Jul 21, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 21, 2025

Uh oh!

Copilot AI Jul 21, 2025

Uh oh!

Copilot AI Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

	const hostname = ghUrl.hostname.trimEnd().toUpperCase();
	const hostname = ghUrl.hostname.trim().toUpperCase();

	elseif ($InstallRoot -like "$env:ProgramFiles\dotnet\?*") {
	elseif ($InstallRoot -match "^$env:ProgramFiles\\dotnet\\.+") {

Conversation

prajjwaldimri commented Jul 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants