BIG REFACTOR#17
Open
Mew2K wants to merge 10 commits into
Open
Conversation
Mew2K
commented
Nov 11, 2024
Mew2K
commented
Member
- Removed sk89 dependency
- Removed lombok dependency
- Updated from Java 8 to Java 21
- Updated plugin to be compatible with Minecraft 1.21.1
- Implemented auto-save feature (worlds automatically save every 5 minutes)
- Modified how command flags are treated; they now work more like Linux command flags.
- Modified /worlds command to allow for better world filtering.
- Copy-pasted some code from https://github.com/Mew2K/Scaffold/tree/mewmastercoder which includes the following key modifications:
- The /archive command actually works now
- Implemented /world alias to /open command
- Switched /export to use file.io as the file-sharing site.
- Removed sk89 dependency - Removed lombok dependency - Updated from Java 8 to Java 21 - Updated plugin to be compatible with Minecraft 1.21.1 - Implemented auto-save feature (worlds automatically save every 5 minutes) - Modified how command flags are treated; they now work more like Linux command flags. - Modified /worlds command to allow for better world filtering. - Copy-pasted some code from https://github.com/Mew2K/Scaffold/tree/mewmastercoder which includes the following key modifications: - The /archive command actually works now - Implemented /world alias to /open command - Switched /export to use file.io as the file-sharing site.
Added other necessary gamerules and world saving on export.
- Better error handling message for /exporting an opened world
- When using /export, a temporary copy of the world is created. This is used to allow a world to be exported even when a player is already inside the world.
- Switch /export from file.io to gofile.io, since file.io's API no longer works after being acquired by Limewire.
World Save on Export
- Should've been done in Warzone@99918c7
- References the github commit on which Scaffold was built, making it easier to tell what version of Scaffold is being used at any given time.
- Fixes issue with /export command not working if it fails to save the world. - Open the target world if it is not currently open so that it can be saved - Notify user in-game if the world failed to save
- Temp file creation is now done inside a "temp" folder within the plugin directory, which is cleared every time the server starts. - Zip file is also explicitly deleted now in the export function, which should've been done in the original implementation and is probably what caused this bug in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.