WDSEN-51: Script cleanup + platform agnostic package changes#84
Open
WDSEN-51: Script cleanup + platform agnostic package changes#84
Conversation
Member
|
JC before she left provided me with a PR that had the build scripts all decoupled to the best she could (since she was VERY busy before she left with project work). There were a few small things that were outstanding, one of them being that The DevContainer on WDS-BT is officially working and building the theme. Once JC's back I'll have her/Amor approve the PR work and we can go over it during our meeting next week, but we can start rolling this out ASAP once approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
WDSEN-51
Link to test
Test Locally
Description
imageminforsharpfor platform agnostic image optimizationRelated Tickets & Documents
Mobile & Desktop Screenshots/Recordings
AI Assistance
Added to documentation?
Added tests?
Testing Instructions
Testing instructions for feature/WDSEN-5-Script-Cleanup:
Testing instructions (WDSEN-5)
npm run lintnpm run buildnpm run lint:phpnpm installor./scripts/update-cursorrules.sh../scripts/update-cursorrules.sh.npm run lighthouseis not in package.json and should not exist.Reviewer's Testing Checklist
As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.
npm run a11y.[optional] Additional Reviewer Notes or Considerations?