Skip to content

feat(core): implement standard logging class#11

Open
thereis wants to merge 3 commits into
WhiskeySockets:masterfrom
thereis:feat/logger-class
Open

feat(core): implement standard logging class#11
thereis wants to merge 3 commits into
WhiskeySockets:masterfrom
thereis:feat/logger-class

Conversation

@thereis

@thereis thereis commented Sep 21, 2025

Copy link
Copy Markdown

This PR introduces a standard library for logging, eliminating the need for console.log.

The reason for this is that when using an observability tool that integrates with pino or any other JSON logging, we can't capture or silence the logs from this library, resulting in poor DX or poor readability.

To silence the libsignal logs, set an environment variable:

LIBSIGNAL_LOG_LEVEL=silent

@jtapeg

jtapeg commented Sep 25, 2025

Copy link
Copy Markdown

That is great

@purpshell

Copy link
Copy Markdown
Member

This PR introduces a standard library for logging, eliminating the need for console.log.

The reason for this is that when using an observability tool that integrates with pino or any other JSON logging, we can't capture or silence the logs from this library, resulting in poor DX or poor readability.

To silence the libsignal logs, set an environment variable:

LIBSIGNAL_LOG_LEVEL=silent

no need for the env variable. please move it to work with pino and then we can embed the socket's logger into there. Then if the user sets his socket logger to silent, he won't hear anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants