Skip to content

fix: bump grpc 1.79.3 and go-jose 4.1.4 for CVE fixes#79

Merged
Will-Luck merged 1 commit into
mainfrom
security/dep-bumps-for-github
Apr 9, 2026
Merged

fix: bump grpc 1.79.3 and go-jose 4.1.4 for CVE fixes#79
Will-Luck merged 1 commit into
mainfrom
security/dep-bumps-for-github

Conversation

@Will-Luck

Copy link
Copy Markdown
Owner

Summary

Close the two fixable Dependabot alerts on this repo with a clean 3-file dep bump. No source changes.

Alerts addressed

Package Current Fix Severity Advisory
google.golang.org/grpc 1.79.1 1.79.3 Critical (CVSS 9.1) CVE-2026-33186
github.com/go-jose/go-jose/v4 (indirect) 4.1.3 4.1.4 High (CVSS 7.5) CVE-2026-34986

Risk analysis

Neither CVE is exploitable on Docker-Sentinel in practice:

  • grpc bypass targets servers using path-based authorization interceptors (e.g. grpc/authz or custom info.FullMethod matching). The cluster gRPC server at internal/cluster/server/server.go:217 uses grpc.NewServer(grpc.Creds(credentials.NewTLS(tlsCfg))) — mTLS at the handshake layer, no path-based authz. There is nothing to bypass.
  • go-jose panic triggers on JWE decryption with a key-wrap alg and empty encrypted_key. Sentinel's OIDC flow uses JWS-signed ID tokens (not JWE). The code path isn't reachable here.

The bumps are still correct for supply-chain hygiene and to close the alert badges.

Not in this PR

  • go.etcd.io/bbolt 1.4.3 (CVE-2026-33817) — no upstream patch yet (first_patched_version: null). Exploit requires a corrupted DB file, which Sentinel's local .db isn't. Will re-evaluate when 1.4.4 ships.

Test plan

Files changed

  • go.mod — 2 lines (grpc + go-jose versions)
  • go.sum — updated hashes
  • CHANGELOG.md — new [Unreleased] / ### Security section

Related work

This PR was developed on the homelab Gitea mirror first (PR #70 on GiteaLN/Docker-Sentinel) where it passed CI and was merged to Gitea main. Because the two main branches have drifted (Gitea main and github main have diverged commit histories), the mirror here is a clean re-apply of just the 3 files rather than a cherry-pick of the Gitea squash commit.

Closes two Dependabot alerts:

* google.golang.org/grpc 1.79.1 -> 1.79.3 closes CVE-2026-33186
  (GHSA-p77j-4mvh-x3m3, gRPC-Go authz bypass via missing leading
  slash in :path). Docker-Sentinel's cluster gRPC server uses mTLS
  with no path-based authz interceptor, so the bypass is not
  exploitable here; this is a supply-chain hygiene bump.

* github.com/go-jose/go-jose/v4 4.1.3 -> 4.1.4 (indirect, via
  coreos/go-oidc/v3) closes CVE-2026-34986 (GHSA-78h2-9frx-2jm8,
  panic in JWE decryption with key-wrap algs and empty
  encrypted_key). Sentinel's OIDC flow uses JWS-signed ID tokens
  not JWE, so the exploit path is low practical risk.

bbolt 1.4.3 (CVE-2026-33817) has no upstream patch yet and is not
addressed here.

Local verification: go build + go vet clean, all tests passing.
@Will-Luck Will-Luck merged commit 54457e0 into main Apr 9, 2026
2 checks passed
@Will-Luck Will-Luck deleted the security/dep-bumps-for-github branch April 9, 2026 23:06
Will-Luck added a commit that referenced this pull request Apr 17, 2026
Closes two Dependabot alerts:

* google.golang.org/grpc 1.79.1 -> 1.79.3 closes CVE-2026-33186
  (GHSA-p77j-4mvh-x3m3, gRPC-Go authz bypass via missing leading
  slash in :path). Docker-Sentinel's cluster gRPC server uses mTLS
  with no path-based authz interceptor, so the bypass is not
  exploitable here; this is a supply-chain hygiene bump.

* github.com/go-jose/go-jose/v4 4.1.3 -> 4.1.4 (indirect, via
  coreos/go-oidc/v3) closes CVE-2026-34986 (GHSA-78h2-9frx-2jm8,
  panic in JWE decryption with key-wrap algs and empty
  encrypted_key). Sentinel's OIDC flow uses JWS-signed ID tokens
  not JWE, so the exploit path is low practical risk.

bbolt 1.4.3 (CVE-2026-33817) has no upstream patch yet and is not
addressed here.

Local verification: go build + go vet clean, all tests passing.

Co-authored-by: Will Luck <noreply@github.com>
Will-Luck added a commit that referenced this pull request Jun 1, 2026
Adds a container-detail hint when the Version Scope hides higher releases. See #83.

Closes #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants