Remove unused forces#35
Open
BurninSun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some UPS issues with milestones on a larger save. Looking into it, the cause is
storage.forcescontaining entries without players doing multiple checks on flow statistics.FactorioMilestones/scripts/storage_init.lua
Line 4 in b09bf1c
This line should ensure no forces without players are being added, however it appears the larger saves I was looking at had entries for forces such as "enemy" which should never be there. I assume those entries were from a previous version but I didn't go through the commit history to figure out how they got there. New games do not have these extra forces stored.
This PR just adds a migration to remove any existing forces without players. It does nothing to make sure that doesn't happen in the future but I don't see any reason it would.