RTC: Allow filtering of SyncConnectionModal#76554
Merged
chriszarate merged 8 commits intotrunkfrom Mar 18, 2026
Merged
Conversation
chriszarate
added
[Type] Enhancement
github-actions
bot
added
[Package] Core data
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
chriszarate
force-pushed
the
feat/sync-connection-modal-filter
branch
from
11184b4 to
4d52807
Compare
ingeniumed
requested changes
Mar 17, 2026
packages/editor/src/components/sync-connection-error-modal/index.tsx
Outdated
Show resolved
Hide resolved
packages/editor/src/components/sync-connection-error-modal/use-retry-countdown.ts
Outdated
Show resolved
Hide resolved
packages/editor/src/components/sync-connection-error-modal/index.tsx
Outdated
Show resolved
Hide resolved
packages/editor/src/components/sync-connection-modal/use-retry-countdown.js
Show resolved
Hide resolved
packages/editor/src/components/sync-connection-error-modal/index.tsx
Outdated
Show resolved
Hide resolved
chriszarate
force-pushed
the
feat/sync-connection-modal-filter
branch
from
97fdeb7 to
94ff2e7
Compare
|
Flaky tests detected in ea17603. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23221695927
|
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
shekharnwagh
approved these changes
Mar 17, 2026
packages/editor/src/components/sync-connection-error-modal/use-retry-countdown.ts
Outdated
Show resolved
Hide resolved
Contributor
|
I think we want to just allow replacing the content inside the modal, not the entire modal component itself, right? This is testing with your example in the description. The red border going behind the overlay seems like a behavior we wouldn't want. Thoughts? 
|
Contributor
Author
That was a bad code example. Generally you just want to return the |
|
Size Change: +28 B (0%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
ingeniumed
approved these changes
Mar 18, 2026
chriszarate
added
the
Backport to WP 7.0 Beta/RC
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 7.0 Editor Tasks
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 18, 2026
* Convert connection modal helpers to TypeScript * Allow filtering of SyncConnectionModal * Rename to SyncConnectionErrorModal * Add ts-ignore for packages without types * Fix the types issue and remove retryAtRef * Resolve manual retry issue * Fix type errors * Wrap in IS_GUTENBERG_PLUGIN check --------- Co-authored-by: chriszarate <czarate@git.wordpress.org> Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org> Co-authored-by: shekharnwagh <shekharnwagh@git.wordpress.org> Co-authored-by: maxschmeling <maxschmeling@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: eff769c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Rename
SyncConnectionModaltoSyncConnectionErrorModaland provide a HOC filter to allow customization by custom sync providers.Closes #76553
Why?
We provide good default error messaging for sync provider connection errors based on error codes. However, a custom sync provider may have custom messaging needs. See #76553 for details.
How?
SyncConnectionModaltoSyncConnectionErrorModalfor better clarity of purpose.editor.SyncConnectionErrorModalfilter to allow custom messaging.disconnectstatuses, additionally show it onconnectingstatuses that exceed the debounce delay.No change to modal appearance or behavior aside from item 3 above.
The refactoring was heavier than anticipated because:
canRetrywas attached to the default error messages whileretryInMswas attached to theConnectionStatus. This work puts both onConnectionStatus, giving more control to custom sync providers.refusage that made the code difficult to follow.The good news is that this code has much greater type safety along with tests.
Testing Instructions
DefaultSyncConnectionErrorModal: