Open
Conversation
t-hamano
commented
Mar 17, 2026
Comment on lines
-41
to
+48
| <Heading as="h2" level={ 3 } weight={ 500 } truncate> | ||
| <Heading | ||
| level={ headingLevel } | ||
| weight={ 500 } | ||
| truncate | ||
| size="20" | ||
| > |
Contributor
Author
There was a problem hiding this comment.
This is the point where the automatic cherry-pick failed, and it's the only place where I had to manually resolve the conflict.
Member
There was a problem hiding this comment.
This adds more props than #76456
Is that intentional?
I also checked trunk
https://github.com/WordPress/gutenberg/blob/trunk/packages/admin-ui/src/page/header.tsx#L44
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
fix/connectors-accessibility-wp7.0
branch
from
ee9ad3e to
9fadfc8
Compare
|
Size Change: +63 B (0%) Total Size: 8.7 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
|
Flaky tests detected in 9fadfc8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23196437168
|
Member
|
Thanks for sorting this backport out manually @t-hamano, much appreciated! |
ramonjd
approved these changes
Mar 18, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
I checked against changes in #76456, and did a quick smoke test. The attributes/role are there, and headings LGTM
The extra props on the <HeadingTag /> in packages/admin-ui/src/page/header.tsx look okay, I guess they need to be added to trunk? Maybe I missed something there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Manually backport #76456 to
wp/7.0Testing Instructions
See #76456