Snackbar: Use surface-width design token for max-width#76592
Open
jameskoster wants to merge 2 commits intotrunkfrom
Open
Snackbar: Use surface-width design token for max-width#76592jameskoster wants to merge 2 commits intotrunkfrom
jameskoster wants to merge 2 commits intotrunkfrom
Conversation
Made-with: Cursor
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
jameskoster
added
[Type] Enhancement
github-actions
bot
removed
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Made-with: Cursor
ciampo
reviewed
Mar 17, 2026
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Nothing to note code-wise, this is more of a design choice. Happy to defer to designers and keep an eye out of the conversation
|
Size Change: -79 B (0%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 81d136f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23203541368
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #76494. Use a
--wpds-dimension-surface-width-*design token for Snackbarmax-width.Why
As part of the ongoing adoption of surface-width design tokens from
@wordpress/theme, the Snackbar's hardcodedmax-width: 600pxcan be replaced with a token from the scale. This brings the Snackbar in line with other components (Dialog, Modal) that have already adopted these tokens.How
Replaced
max-width: 600pxwithvar(--wpds-dimension-surface-width-lg)(560px) inpackages/components/src/snackbar/style.scss.Note
The previous value of 600px sits between
lg(560px) andxl(720px) on the token scale, so there isn't an exact match. This PR useslgto keep the Snackbar compact, but I'm open to feedback if there's a feeling thatxl(720px) would be more appropriate.