RTC: Keep sync engine running even when there are no providers#76602
Open
chriszarate wants to merge 1 commit intotrunkfrom
Open
RTC: Keep sync engine running even when there are no providers#76602chriszarate wants to merge 1 commit intotrunkfrom
chriszarate wants to merge 1 commit intotrunkfrom
Conversation
chriszarate
added
[Type] Task
|
Size Change: -15 B (0%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Keep sync engine "running" even when there are no registered sync providers.
Why?
When real-time collaboration is disabled, what we really mean is that we want to disable sharing updates with other collaborators and use the existing post locking functionality.
However, representing entities as Yjs documents and keeping them up-to-date still has value. We can continue to battle-test the performance and undo functionality. We can also add new bindings to the sync manager that power new features like suggested edits, regardless of whether RTC is enabled.
How?
Remove early return when there are no registered sync providers.