Fix SCF user profile field table layout on profile/edit screens#387
Open
meravi wants to merge 4 commits intoWordPress:trunkfrom
Open
Fix SCF user profile field table layout on profile/edit screens#387meravi wants to merge 4 commits intoWordPress:trunkfrom
meravi wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Scope layout CSS to profile/user-edit screens using wp_add_inline_style. Limit width rules to text-like inputs, textarea, and select2 to avoid side effects. Add PHPUnit coverage for generated user form layout CSS. Fixes WordPress#349
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This fixes the layout issue from #349 on user profile/edit screens where SCF fields can look misaligned inside the WordPress
form-table.I moved the styling fix into the normal enqueue flow using
wp_add_inline_style()and limited it to user profile/edit admin screens only.Changes
ACF_Form_User::admin_enqueue_scripts()profileuser-editprofile-networkuser-edit-networkWhy
My previous attempt fixed the UI issue, but this version keeps the implementation cleaner and closer to WordPress coding standards, with narrower scope to avoid side effects.
Related
Fixes #349
Fixes https://github.com/WordPress/secure-custom-fields/issues/349