Fix _load_textdomain_just_in_time notice on WordPress 6.7+#392
Fix _load_textdomain_just_in_time notice on WordPress 6.7+#392trajche wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Replace load_textdomain() with load_plugin_textdomain() in acf_load_textdomain() for proper integration with the just-in-time translation loading system introduced in WordPress 6.7. Fixes WordPress#252
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nmwaipopo. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This was not an issue with SCF. It was caused by other plugins registering options page/acf fields too early, which initalized SCF. By wrapping it in |
Summary
load_textdomain()withload_plugin_textdomain()inacf_load_textdomain()for proper integration with the just-in-time translation loading system introduced in WordPress 6.7._load_textdomain_just_in_time was called incorrectlynotice that appears on WordPress 6.7+ installations.Fixes #252
Test plan
WP_DEBUGandWP_DEBUG_DISPLAYenabled_load_textdomain_just_in_timenotice appears for thesecure-custom-fieldsdomain