-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Tests: Add unit tests for object_ids handling in WP_Term_Query
#10634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Tests: Add unit tests for object_ids handling in WP_Term_Query
#10634
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
01cb280 to
9566ab1
Compare
|
I've added 3d7f52a to account for the case for when someone may have supplied |
|
Alas, the |
Trac ticket: https://core.trac.wordpress.org/ticket/63256
Adds unit test coverage for the fix implemented in #8668 that addresses unnecessary
array_map()processing inWP_Term_Query::get_terms()whenobject_idsis not set.This PR -
object_idsisnull(default), all terms are returned without filteringarray_map()processing0) is treated as a valid object ID0might be incorrectly treated as emptyTesting
Follows the patch of #8668 by @dilipbheda
Props: @dilipbheda for the original patch