Skip to content

Conversation

@SirLouen
Copy link
Member

Following the patch in 45035.diff by @gwelser, I have refreshed and updated to work.

Testing Instructions

  1. Add a new CPT
  2. Set the at_a_glance argument to true in that CPT
  3. Create a couple posts in that CPT, some published some not published
  4. Go to the admin dashboard, and check if "At a Glance" show the right number of published posts

Trac ticket: https://core.trac.wordpress.org/ticket/45035


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sirlouen, westonruter, mukesh27, pbiron.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

@pbiron pbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR seems to work.

Have added 1 comment regarding the need to add at_a_glance arg to the hash in the register_post_type() DocBlock.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@pbiron
Copy link

pbiron commented Dec 20, 2025

The other thing this PR should do is output relevant CSS that uses the menu_icon param to register_post_type() for the icon in the At a Glance item. Have to think a bit about the best way to do that, especially to for menu_icon being an inline SVG.

@SirLouen SirLouen requested a review from westonruter December 22, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants