fix: require logspark[json] to pull python-json-logger#148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LogSpark 0.10.2 (pinned in 6.0.5) requires
python-json-loggerforSparkJsonHandler. WrenchCL was pinninglogspark>=0.10.2without the[json]extra, sopython-json-loggerwas not installed. Any ECS service running in deployment mode (which usesSparkJsonHandlerfor structured JSON logs) crashes on startup with:This caused
model-input-builder-prepto exit code 1 inside theai-pipelineStep Function, making every scheduled pipeline run fail. All other ECS services rebuilt at the same time will hit the same crash on their next invocation.Fix
Changed
logspark>=0.10.2tologspark[json]>=0.10.2so the JSON extra (and itspython-json-loggertransitive dependency) is always installed with WrenchCL.End-user impact
Restores pipeline execution for all ECS services. Without this fix, every service rebuilt against WrenchCL 6.0.5 crashes at startup.