fix(incident): use lowercase needswrenchbotcheck field key#18
Merged
Conversation
Datadog stores the field as 'needswrenchbotcheck' (all lowercase). The previous casing 'NeedsWrenchBotCheck' was silently discarded by the API — the PATCH returned 200 but the field never landed on the incident, which is why the notification rule never fired.
Kydoimos97
requested review from
a team,
Wrench-Service-Bot and
Copilot
and removed request for
Copilot
Wrench-Service-Bot
approved these changes
Jun 10, 2026
Wrench-Service-Bot
left a comment
Wrench-Service-Bot
left a comment
There was a problem hiding this comment.
PR Review
Verdict: APPROVED
Description
Fixes a silent bug where setting the needswrenchbotcheck Datadog incident field via puppy-kit had no effect — the API accepted the wrong-cased key (NeedsWrenchBotCheck) with a 200 but never persisted the field, so the notification rule never fired.
Highlights
- Root cause investigation is thorough and evidence-based: verified correct key by reading a known-good incident, then confirmed the wrong-cased PATCH left the field absent on read-back
- Fix is minimal and surgical — one line in source, one line in tests
- Test updated in lockstep; the assertion now verifies the exact key Datadog persists
Style Notes
- None
Overall Assessment
This is a one-line correctness fix with a well-documented root cause and an updated test. The fix unblocks the triage webhook notification rule that depended on this field being set. Ready to merge.
Sources
- Diff: 2 files, +2/-2
- Prior reviews: none
- Related PRs/issues: N/A
— Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
needswrenchbotcheckfield was being patched with the keyNeedsWrenchBotCheck(PascalCase). Datadog stores and matches the field asneedswrenchbotcheck(all lowercase). The API silently accepted the wrong-cased key, returned 200, but the field never landed on the incident — meaning the Datadog notification rule never fired.Root cause
Discovered by checking an incident that was already correctly triaged: its fields showed
needswrenchbotcheck(lowercase). The incident being patched showed the field as absent. Direct verification: PATCH withNeedsWrenchBotCheck→ field not present on read-back. This is the reason the retrigger sweep toggled 32 incidents with zero webhook fires.End-user impact
The
--needs-wrench-bot-checkflag now actually works. Setting it toyesvia the CLI or MCP will land the field on the incident and trigger the Datadog notification rule that fires the triage webhook.