Fix msig:propose serialization for non-name fields#37
Open
paulgnz wants to merge 1 commit intoXPRNetwork:masterfrom
Open
Fix msig:propose serialization for non-name fields#37paulgnz wants to merge 1 commit intoXPRNetwork:masterfrom
paulgnz wants to merge 1 commit intoXPRNetwork:masterfrom
Conversation
The propose command failed with "Name should be less than 13 characters" when proposing msig transactions containing actions with u64/u128 fields (e.g. poolId: 265). The bug occurred because api.transact() recursively re-serialized already-serialized action data within the nested transaction, treating hex strings as structured JSON. Fix: manually serialize the inner transaction and propose action data to raw bytes, bypassing the library's recursive serialization. The inner actions are still properly serialized via api.serializeActions() using contract ABIs — only the final assembly is done manually. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msig:proposefailing with "Name should be less than 13 characters" when proposing transactions with u64/u128 action fields (e.g.poolId: 265)api.transact()recursively re-serializes already-serialized action data in the nestedtrxfield, treating hex strings as structured JSONapi.serializeActions(), bypassing recursive serializationReproduction
Test plan
npm run build)msig:proposewithsimpledex::forcerempool({poolId: 265})— proposal created successfullymsig:approveandmsig:execunchanged (no nested transactions)🤖 Generated with Claude Code