228 refactor graphics::window into lvgl component#229
Merged
AlixANNERAUD merged 18 commits intoMay 27, 2026
Conversation
…sistency and performance
…ability and efficiency
…ext initialization
…nd improve readability
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the codebase to consistently use the new
OwnedWindowabstraction in place of the previousWindowtype across multiple modules. It also modernizes control flow by adopting Rust's let-chaining (if ... && let ...) and improves code readability by simplifying match and event handling patterns. The changes enhance maintainability, safety, and consistency in UI window management and event processing.Refactoring to
OwnedWindowabstraction:Windowtype withOwnedWindowin theFileManager,Settings,Desk, andLoginstructs, updating all associated window method calls to useas_object_mutable()oras_mut()as appropriate. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]Modernizing control flow and event handling:
if ... && let ...) for more concise and readable conditional logic in functions likesplit_host_portandrender_cpuinfo_text. [1] [2]Deskandscreen_event_handlerimplementations. [1] [2] [3] [4] [5]Code cleanup and minor improvements:
These changes collectively improve code consistency, readability, and future maintainability by unifying window management and adopting modern Rust idioms.