Add support to include ThunderSVM from another cmake project#255
Open
sbreuss wants to merge 1 commit intoXtra-Computing:masterfrom
Open
Add support to include ThunderSVM from another cmake project#255sbreuss wants to merge 1 commit intoXtra-Computing:masterfrom
sbreuss wants to merge 1 commit intoXtra-Computing:masterfrom
Conversation
This commit changes the cmake files to allow the usage of ThunderSVM as a submodule within other projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to use ThunderSVM as part of a different cmake project.
This currently fails, as current master relies on
CMAKE_BINARY_DIRPROJECT_SOURCE_DIRCMAKE_BINARY_DIRI changed the usage of these variables to use the
CURRENTversions with relative paths from there.With this changes, everything works as expected.